Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Service Worker and Favicon #3142

Merged
merged 2 commits into from Jun 13, 2019

Conversation

maestromac
Copy link
Member

@maestromac maestromac commented Jun 12, 2019

What type of PR is this? (check all applicable)

  • Misc

Description

If Service-Worker ever decides to serve 500.html, an error will now be outputted to the browser.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 12, 2019
@maestromac maestromac changed the title Update favicon Update Service Worker and Favicon Jun 12, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 13, 2019
@benhalpern benhalpern merged commit 0af2a0a into forem:master Jun 13, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 13, 2019
@maestromac maestromac deleted the mac/misc/update-favicon branch June 13, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants