Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons size in Safari reader mode #3157

Merged

Conversation

maximelafarie
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

In Safari reader mode, icons become simply huge. I used the unused class which is added to icons only in reader mode: .reader-image-tiny.

Default view:
image

Safari reader mode view:
image

Related Tickets & Documents

I saw nothing about that.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

The same on Apple smartphones

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

excited
(impatient given that it's my first contribution to this awesome project 馃)

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 14, 2019
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I learned about reader-image-tiny. Interesting!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 14, 2019
@benhalpern benhalpern merged commit e15a1ad into forem:master Jun 14, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants