Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Dashboard Pro code #3161

Merged
merged 1 commit into from Jun 14, 2019
Merged

Remove old Dashboard Pro code #3161

merged 1 commit into from Jun 14, 2019

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Jun 14, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

There's a Dashboard::Pro class that was lying around, I think it predates the AnalyticsService @Zhao-Andy started. Since it's not used anywhere, I'm going to remove it

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 14, 2019
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I believe all the data is grabbed from the API now so this should be fine.

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 14, 2019
@maestromac maestromac merged commit 272e032 into forem:master Jun 14, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 14, 2019
@rhymes rhymes deleted the rhymes/remove-dashboard-pro-facade branch June 14, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants