Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint issues in initializeSettings.js #4329

Merged
merged 1 commit into from Oct 9, 2019
Merged

Fix eslint issues in initializeSettings.js #4329

merged 1 commit into from Oct 9, 2019

Conversation

Amorpheuz
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • eslint configuration moved comments to a separate line on running pre-commit hook allowing the eslint disable-line to not work correctly.
  • switched to eslint-disable-next-line to fix the same

Related Tickets & Documents

#3777

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

- eslint configuration moved comments to a seperate line
  in pre commit hook allowing the eslint-disable-line to
  not work correctly.
- switched to eslint-disable-next-line to fix the same
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 9, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 9, 2019
@benhalpern benhalpern merged commit e7c4310 into forem:master Oct 9, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 9, 2019
RakChamp25 pushed a commit to RakChamp25/dev.to that referenced this pull request Oct 15, 2019
- eslint configuration moved comments to a seperate line
  in pre commit hook allowing the eslint-disable-line to
  not work correctly.
- switched to eslint-disable-next-line to fix the same
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants