-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tags 'View Rules' disappearing bug (Firefox) #5732
Conversation
(activeElement.id === 'tag-input' || | ||
activeElement.classList.contains( | ||
'articleform__tagsoptionrulesbutton', | ||
) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an FYI, I didn't format it like this. This is what the pre-commit linter spit out.
Thanks for this @sunny-b! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sunny-b!
Tested it manually on Firefox 73b9 and Chrome 79 and it works great!
ps. @sunny-b, remember to name your branches sunny-b/TOPIC-ISSUE_ID
according to the contributing guide in the future
@rhymes oops sorry. Forgot about that |
What type of PR is this? (check all applicable)
Description
I noticed that, in Firefox, when I'm writing an article and attempt to search for a tag, the tags list will disappear if I click "View Rules" for a certain tag. Only after I bring the tags search back up am I able to view the tag rules.
Screencast:
It looks like when the "View Rules" button is clicked, Chrome considers the button to be the
activeElement
while Firefox considers the entire tag row to be theactiveElement
, causing the eventHandler not to work as expected.This PR fixes it so Firefox works as expected.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?