Fix tags 'View Rules' disappearing bug (Firefox) #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny-b
commented
Jan 26, 2020
| (activeElement.id === 'tag-input' || | ||
| activeElement.classList.contains( | ||
| 'articleform__tagsoptionrulesbutton', | ||
| ) || |
There was a problem hiding this comment.
Just an FYI, I didn't format it like this. This is what the pre-commit linter spit out.
|
Thanks for this @sunny-b! 👍 |
rhymes
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Thanks @sunny-b!
Tested it manually on Firefox 73b9 and Chrome 79 and it works great!
ps. @sunny-b, remember to name your branches sunny-b/TOPIC-ISSUE_ID according to the contributing guide in the future
pr-triage
bot
added
PR: reviewed-approved
|
@rhymes oops sorry. Forgot about that |
benhalpern
approved these changes
Jan 27, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I noticed that, in Firefox, when I'm writing an article and attempt to search for a tag, the tags list will disappear if I click "View Rules" for a certain tag. Only after I bring the tags search back up am I able to view the tag rules.
Screencast:
It looks like when the "View Rules" button is clicked, Chrome considers the button to be the
activeElementwhile Firefox considers the entire tag row to be theactiveElement, causing the eventHandler not to work as expected.This PR fixes it so Firefox works as expected.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?