Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant yarn install command #5764

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Removed redundant yarn install command #5764

merged 1 commit into from
Jan 27, 2020

Conversation

nickytonline
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

A very minor update to the Docker documentation. Yarn by default installs packages by simply running yarn. See the Yarn Install.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • [] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Bruce Banner changes into Hulk

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 27, 2020
maestromac
maestromac approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 27, 2020
jacobherrington
jacobherrington approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to prefer more explicit documentation when possible, but in this case, I think this is totally fine. 👍

@jacobherrington jacobherrington merged commit c91080c into master Jan 27, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 27, 2020
@nickytonline nickytonline deleted the nickytonline/update-docker-install-docs branch January 27, 2020 18:10
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@vaidehijoshi vaidehijoshi vaidehijoshi approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

@maestromac maestromac maestromac approved these changes

@joshpuetz joshpuetz Awaiting requested review from joshpuetz

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nickytonline @rhymes @vaidehijoshi @jacobherrington @maestromac