Remove Foreman gem

[citizen428]

What type of PR is this? (check all applicable)

• Update

Description

This removes the Foreman gem, as per the author's recommendation:

Ruby users should take care not to install foreman in their project's Gemfile. See this wiki article for more details.

Related Tickets & Documents

n/a

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

• docs.dev.to
• readme
• no documentation needed

[rhymes]

Seems very reasonable, though the PR that introduced this is from March 2019, which makes me think there was something else going on

#2143

I couldn't find it though

[citizen428]

@rhymes Nothing was going on from what I can tell. Thor was updated, Foreman wasn't yet. We left a note to update Foreman once it had released the new version with an updated dependency, which didn't happen until 0.86.0 released in October 2019. Foreman 0.85.0 had the dependency listed as thor ~> 0.19.1.

[rhymes]

I still think we shouldn't have foreman in our Gemfile:

Ruby users should take care not to install foreman in their project's Gemfile. See this wiki article for more details.

and the wiki link is title "Don't Bundle Foreman" :D https://github.com/ddollar/foreman/wiki/Don't-Bundle-Foreman

though having it enabled only in development mode should be safe enough

[citizen428]

@rhymes Agreed, I usually don't bundle it. But since this project does and had a pretty outdated comment, I updated Foreman. I'd be just as happy removing it.

[rhymes]

Let's see what @maestromac thinks, I'm definitely down to removing it and add it to the installation guide

[maestromac]

Oh yes! Let's remove foreman from our app and have a separate step for installing foreman to our guide.

[citizen428]

@rhymes & @maestromac Removed Foreman and updated the docs.

[rhymes]

Loks good!

I wonder if it'd make sense to link this new "others" page in a note in this other page: https://docs.dev.to/getting-started/start-app/

In case people run bin/startup and they don't have foreman installed:

➜  devto git:(citizen428/update-foreman) ✗ bin/startup
== STARTING UP ==
Traceback (most recent call last):
	4: from /Users/rhymes/.rvm/gems/ruby-2.6.5/bin/ruby_executable_hooks:24:in `<main>'
	3: from /Users/rhymes/.rvm/gems/ruby-2.6.5/bin/ruby_executable_hooks:24:in `eval'
	2: from /Users/rhymes/.rvm/gems/ruby-2.6.5/bin/foreman:23:in `<main>'
	1: from /Users/rhymes/.rvm/gems/ruby-2.6.5/gems/bundler-2.0.2/lib/bundler/rubygems_integration.rb:480:in `block in replace_bin_path'
/Users/rhymes/.rvm/gems/ruby-2.6.5/gems/bundler-2.0.2/lib/bundler/rubygems_integration.rb:460:in `block in replace_bin_path': can't find executable foreman for gem foreman. foreman is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)

== Command ["bundle exec foreman start -f Procfile.dev"] failed ==

[citizen428]

@rhymes Makes total sense, added a note there.

[rhymes]

LGTM!

[jacobherrington]

I think this makes sense 👍