Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Flipflop with Sail #841

Merged
merged 10 commits into from Dec 18, 2018
Merged

Replace Flipflop with Sail #841

merged 10 commits into from Dec 18, 2018

Conversation

vinistock
Copy link
Contributor

@vinistock vinistock commented Oct 6, 2018 •
edited by maestromac

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Replaces Flipflop with Sail as described in the related issue. The idea is to allow people to take a look at Sail and see if it fully fits the needs.

I am available to make changes to Sail if need be and also expand the work here.

This is my first contribution to dev.to, so please let me know if I'm breaking any code conventions.

Related Tickets & Documents

Resolves #686

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@benhalpern
Copy link
Contributor

@jessleenyc wanna give this one a look? More context in the linked issue.

jessleenyc
jessleenyc requested changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@jessleenyc jessleenyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I visit /sail, I'm seeing the below. Is there something else I need to do to actually see the features to toggle?

db/migrate/20181001225906_create_sail_settings.rb Outdated Show resolved Hide resolved
config/application.rb Show resolved Hide resolved
@vinistock
Copy link
Contributor Author

@jessleenyc you should have seen the settings when you visited the dashboard. Did you database get populated properly after you ran the migration? I will double check the migration to see if it is populating the database.

@jessleenyc
Copy link
Contributor

jessleenyc commented Oct 10, 2018 •
edited

@vinistock I ran the migration but it looks like the table created properly but the data didn't seed properly.

@vinistock
Copy link
Contributor Author

@jessleenyc I have pushed a commit addressing your concerns. Let me know what you think and if there's anything else you wish to change. However, it seems the build and the codeclimate report might have gotten stuck for some reason.

jessleenyc
jessleenyc approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@jessleenyc jessleenyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! @maestromac will you take a quick look at as well?

@weekly-digest weekly-digest bot mentioned this pull request Oct 29, 2018
Closed
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Nov 12, 2018
maestromac
maestromac reviewed Dec 5, 2018
View reviewed changes
config/routes.rb Outdated Show resolved Hide resolved
maestromac
maestromac approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it took so long. This is Awesome 👍 ! Works great!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Dec 5, 2018
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Dec 5, 2018
@vinistock
Copy link
Contributor Author

@maestromac Just pushed another commit moving the setting creation from the migration to the config YAML file. Could you please do a quick re-test and make sure everything is fine?

I'd do it myself, but my development environment needs some attention for dev.to. It's complaining about missing database.yml and I see it is in the gitignore file, so my environment must be outdated.

@maestromac maestromac force-pushed the replace_flipflop_by_sail branch 2 times, most recently from c2dc835 to 67d234f Compare December 5, 2018 23:51
@benhalpern benhalpern merged commit 21870e8 into forem:master Dec 18, 2018
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Dec 18, 2018
maestromac added a commit that referenced this pull request Dec 18, 2018
@maestromac
Revert "Replace Flipflop with Sail (#841)"
06e0cba 
This reverts commit 21870e8.
@benhalpern
Copy link
Contributor

We hit an error while trying to merge this, so we're going to try and get Sail in one step at a time.

@vinistock
Copy link
Contributor Author

@benhalpern can you disclose which error happened? Is it something that could be fixed in Sail?

@vinistock vinistock deleted the replace_flipflop_by_sail branch December 19, 2018 00:12
@maestromac
Copy link
Member

@vinistock we are still uncertain on what crashed production and it could be our end. We are setting up a production test environment and will deploy more Sail changes there first. I'll keep you posted on connect.

@rhymes rhymes mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maestromac maestromac maestromac approved these changes

@jessleenyc jessleenyc jessleenyc approved these changes

@benhalpern benhalpern Awaiting requested review from benhalpern

Assignees

@maestromac maestromac

Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vinistock @CLAassistant @benhalpern @jessleenyc @maestromac