Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action icons in dark themes #9177

Merged
merged 42 commits into from Jul 7, 2020
Merged

Fix action icons in dark themes #9177

merged 42 commits into from Jul 7, 2020

Conversation

ludwiczakpawel
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR fixes and issue with one of the icon in action bar being hardly visible on dark themes.

QA Instructions, Screenshots, Recordings

Before:
image

After:
image

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@ludwiczakpawel
flare tag line height
f6f8e4c
@ludwiczakpawel
.
826f0cd
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
c2cb3df
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
4452b51
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
8920b57
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
9e2e3ac
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
554daf3
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
2ec1b1c
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
372f081
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
3cd2c1d
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
edfd43a
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
74da84d
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
fa8625c
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
9e30971
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
3212043
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
353bf59
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
c73e537
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
97fb35d
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
3ecc709
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
c38ea9c
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
75d05f1
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
7e90aee
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
659c1d9
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
effe9b4
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
00ab3ca
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
6d1fbc5
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
11db2a9
@ludwiczakpawel
Merge branch 'master' of https://github.com/thepracticaldev/dev.to
e7d0ab2
@ludwiczakpawel
dropdown fix + actions bar fix
159607c
@ludwiczakpawel
actions bar on mob
73daac5
@ludwiczakpawel ludwiczakpawel requested review from rhymes, benhalpern and a team July 7, 2020 06:39
@ludwiczakpawel ludwiczakpawel requested a review from a team as a code owner July 7, 2020 06:39
@ludwiczakpawel ludwiczakpawel self-assigned this Jul 7, 2020
@ludwiczakpawel ludwiczakpawel requested review from jacobherrington and fdocr and removed request for a team July 7, 2020 06:39
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jul 7, 2020
@rhymes rhymes changed the title Actions icon fix Fix action icons in dark themes Jul 7, 2020
rhymes
rhymes approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jul 7, 2020
@ludwiczakpawel ludwiczakpawel merged commit e67df7e into forem:master Jul 7, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Jul 7, 2020
@jmau111 jmau111 mentioned this pull request Oct 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

@benhalpern benhalpern Awaiting requested review from benhalpern

@fdocr fdocr Awaiting requested review from fdocr

Assignees

@ludwiczakpawel ludwiczakpawel

Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ludwiczakpawel @rhymes @jacobherrington