Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Admin interface paths #9576

Merged
merged 3 commits into from Aug 3, 2020
Merged

Move Admin interface paths #9576

merged 3 commits into from Aug 3, 2020

Conversation

joshpuetz
Copy link
Contributor

@joshpuetz joshpuetz commented Jul 30, 2020 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Moves admin interfaces from /admin to /resource_admin in order the clear the way for future movement of /internal to /admin. See issue forem/InternalProjectPlanning#5 for more details!

Next steps will be to:

  • move /internal to /admin
  • remove administrate, and move these interfaces back up under /admin

Related Tickets & Documents

Part of forem/InternalProjectPlanning#5

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@joshpuetz joshpuetz added area: admin admin panel internal team only internal tasks only for Forem team members labels Jul 30, 2020
@joshpuetz joshpuetz self-assigned this Jul 30, 2020
@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Jul 31, 2020
@joshpuetz joshpuetz changed the title Reorganize Admin interface paths Move Admin interface paths Jul 31, 2020
@joshpuetz joshpuetz requested review from a team, citizen428, fdocr and rhymes and removed request for a team July 31, 2020 18:34
@joshpuetz joshpuetz marked this pull request as ready for review July 31, 2020 21:41
@joshpuetz joshpuetz requested review from jacobherrington and a team as code owners July 31, 2020 21:41
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jul 31, 2020
mstruve
mstruve approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually fewer places than I would have thought 🚀

@pr-triage pr-triage bot added the PR: partially-approved bot applied label for PR's where a single reviewer approves changes label Jul 31, 2020
Ridhwana
Ridhwana approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@Ridhwana Ridhwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@benhalpern benhalpern merged commit cda18d0 into master Aug 3, 2020
@benhalpern benhalpern deleted the joshpuetz/reorg-admin-paths branch August 3, 2020 12:49
@pr-triage pr-triage bot added the PR: merged bot applied label for PR's that are merged label Aug 3, 2020
@joshpuetz joshpuetz mentioned this pull request Aug 4, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 approved these changes

@mstruve mstruve mstruve approved these changes

@Ridhwana Ridhwana Ridhwana approved these changes

@benhalpern benhalpern benhalpern approved these changes

@fdocr fdocr Awaiting requested review from fdocr

@rhymes rhymes Awaiting requested review from rhymes

@jacobherrington jacobherrington Awaiting requested review from jacobherrington

Assignees

@joshpuetz joshpuetz

Labels
area: admin admin panel internal team only internal tasks only for Forem team members PR: draft bot applied label for PR's that are a work in progress PR: merged bot applied label for PR's that are merged PR: partially-approved bot applied label for PR's where a single reviewer approves changes PR: unreviewed bot applied label for PR's with no review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joshpuetz @citizen428 @mstruve @Ridhwana @benhalpern