Remove ENVied Gem, Use dotenv Take 2

[mstruve]

What type of PR is this? (check all applicable)

• Refactor

Description

This is a followup to #9621. The difference between the original and this is the migration script. Now the migration

• does NOT remove the application.yml file. This allows users that may have issues with the migration not to lose their keys which @rhymes and I(yeah I did it too when I creating this) were both victims to.
• It sets default values that may not be present in the application.yml file. These default however have been added to the .env_sample file so going forward they should always be present for users starting fresh.

TODO: Remove sample application yml file and Figaro gem

Related Tickets & Documents

QA Instructions

You dont have to do all of these but if you want to give it a thorough test.

• Pull down branch
• run bin/setup
• Ensure app still runs
• run bin/setup again to make sure no errors
• Ensure app still runs
• force kill app and boot it back up, should still run

[mstruve]

@rhymes I found with your script the colons within the default URLs got swapped out for = which we dont want so I switched back to this way. I also couldn't find the commit even after fetching all so I went ahead and copied your code into my own commit.

[rhymes]

Perfect! :-)

[rhymes]

The script apparently works, then I booted the app, clicked around but http://localhost:3000/dashboard crashed and in the logs I can see the following:

ActionView::Template::Error - Must supply api_secret:
  app/views/shell/_top.html.erb:37:in `view template'
  app/controllers/shell_controller.rb:9:in `top'

It looks like it's looking for some Cloudinary configuration...

forem/app/views/shell/_top.html.erb

Line 37 in d8ec6cb

<link rel="apple-touch-icon" href="<%= cloudinary(SiteConfig.logo_png, 180, "png") %>">

[rhymes]

Tried the script, it worked, the app boots up correctly as well.

I haven't tested the container setup though

[maestromac]

I had to remove some personal commented out env var but this works. On a slightly unrelated note, I got a lot of WARNING .. Key already set which is gone after I remove my application.yml.

Tested and working locally!

[mstruve]

@citizen428 can you poke around the container setup and let me know if you see anything not working? Please and THANK YOU!

[mstruve]

Yeah @maestromac you have to live with those warnings until application.yml is removed manually or when we remove the Figaro gem