From 76752114faa1a427d4fa680c3570ccde8218c0bf Mon Sep 17 00:00:00 2001 From: Josquin Debaz Date: Fri, 15 Mar 2024 16:58:35 +0100 Subject: [PATCH] B7161682765: Remove unused eventCategory.off() method --- src/eventCategory.js | 15 --------------- test/events.test.js | 13 ------------- 2 files changed, 28 deletions(-) diff --git a/src/eventCategory.js b/src/eventCategory.js index 8d99a2f..3f72d03 100644 --- a/src/eventCategory.js +++ b/src/eventCategory.js @@ -43,21 +43,6 @@ export default function eventCategory() { return ensureEventHolderFor(name).register(callback); }; - /** - * Removed "binding" attached to event. - * @deprecated use unregister() instead - * @param name {String} Name of event - * @param binding {eventBinding} Binding - */ - that.off = function (name, binding) { - // eslint-disable-next-line no-console - console.warn( - "Sending off() to a category is deprecated. Send unregister() instead.", - ); - - return that.unregister(name, binding); - }; - /** * Removed "binding" attached to event. * @param name {String} Name of event diff --git a/test/events.test.js b/test/events.test.js index 46ddaee..a8eef8e 100644 --- a/test/events.test.js +++ b/test/events.test.js @@ -278,19 +278,6 @@ describe("deprecated", () => { console.warn = originalConsoleWarn; }); - it("off() category method delegates to unregister", () => { - // Arrange: an event - let someEvents = eventCategory(); - let spy = jasmine.createSpy("unregister"); - - someEvents.unregister = spy; - - someEvents.off("namedEvent", "something else"); - - expect(spy).toHaveBeenCalledWith("namedEvent", "something else"); - expect(console.warn).toHaveBeenCalled(); - }); - it("onceOn() category method delegates to registerOnce", () => { // Arrange: an event let someEvents = eventCategory();