In v1.3.0, cannot kill child process when using control-c in Windows

[wlingke]

I am working in a Windows environment. In 1.2.3, when you hit control-c to exit the forever-monitor process, it also killed the child process. However, in 1.3.0, when you hit control-c, you only kill the forever-monitor process but the child process remains.

[wlingke]

Setting killTree: true also doesn't solve this issue

[matthewrobb]

Any changes with this?

[wlingke]

haven't heard anything... staying on 1.2.3 til otherwise

[matthewrobb]

@wlingke Do you do anything to get the stdout piped to the main proc? Using inherit breaks with the older versions.

[wlingke]

The stdout pipes normally to the main process for me. Not sure what you
mean by using inherit
ᐧ

Best,
Lingke

Lingke Wang
Stanford GSB '16

On Fri, Mar 13, 2015 at 8:20 AM, Matthew Robb notifications@github.com
wrote:

@wlingke https://github.com/wlingke Do you do anything to get the
stdout piped to the main proc? Using inherit breaks with the older versions.

—
Reply to this email directly or view it on GitHub
#80 (comment)
.

[wlingke]

any luck on this issue? This still persists in the latest forever monitor

[CaleyD]

I ran into the same problem. It looks like killTree was explicitly disabled for Windows.
See 8dd9ba1 and #52

[wlingke]

good job on finding issue. I'm not sure why it was disabled. The command used to work in 1.2.x

[v3xx3d]

Does anyone know how to actually fix this? Just disabling it for windows doesn't seem to resolve anything other than hiding a known issue.

[boysmovie]

What I did was to setup the SIGINT event and when Control-C is triggered just call child.stop()

process.on('SIGINT', function() {
    child.stop();
    process.exit();
});