closes #164 and #235 fix wrong usage of matchBase option of minimatch, use relative to watchDirectory path for matching #274

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

kof commented May 4, 2012

This has fixed the issue for me.

closes #164 and #235 fix wrong usage of matchBase option of minimatch…
…, use relative to watchDirectory path fore matching
Contributor

kof commented May 4, 2012

however console.error( minimatch('tmp/public/app/css/main.css', 'tmp/*', { matchBase: true })); // false

I think minimatch is somehow broken.

Contributor

kof commented May 4, 2012

ok its my fault

isaacs/minimatch#8

Contributor

AvianFlu commented May 4, 2012

Cherry-picked in 44c2337 - thanks!

For future reference, we tend to lump groups of changes together into releases - as such, I removed the version bump from your commit. I'll be bumping and publishing 0.9.1 after a little bit more testing later today.

@AvianFlu AvianFlu closed this May 4, 2012

Contributor

kof commented May 5, 2012

Well, if I understand correctly semver, patch number should be increased if any public functionality was changed. This is the case here so, I don't really understand why do you want to group changes. Publishing a new version doesn't cost money and there are enough numbers. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment