Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

closes #164 and #235 fix wrong usage of matchBase option of minimatch, use relative to watchDirectory path for matching #274

Closed
wants to merge 1 commit into from

2 participants

@kof
kof commented

This has fixed the issue for me.

@kof kof closes #164 and #235 fix wrong usage of matchBase option of minimatch…
…, use relative to watchDirectory path fore matching
1a478ba
@kof
kof commented

however console.error( minimatch('tmp/public/app/css/main.css', 'tmp/*', { matchBase: true })); // false

I think minimatch is somehow broken.

@kof
kof commented

ok its my fault

isaacs/minimatch#8

@AvianFlu

Cherry-picked in 44c2337 - thanks!

For future reference, we tend to lump groups of changes together into releases - as such, I removed the version bump from your commit. I'll be bumping and publishing 0.9.1 after a little bit more testing later today.

@AvianFlu AvianFlu closed this
@kof
kof commented

Well, if I understand correctly semver, patch number should be increased if any public functionality was changed. This is the case here so, I don't really understand why do you want to group changes. Publishing a new version doesn't cost money and there are enough numbers. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 4, 2012
  1. @kof

    closes #164 and #235 fix wrong usage of matchBase option of minimatch…

    kof authored
    …, use relative to watchDirectory path fore matching
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 4 deletions.
  1. +4 −2 lib/forever/plugins/watch.js
  2. +2 −2 package.json
View
6 lib/forever/plugins/watch.js
@@ -18,8 +18,10 @@ function watchFilter(fileName) {
return false;
}
+ fileName = path.relative(this.watchDirectory, fileName);
+
for (var key in this.watchIgnorePatterns) {
- if (minimatch(fileName, this.watchIgnorePatterns[key], { matchBase: this.watchDirectory })) {
+ if (minimatch(fileName, this.watchIgnorePatterns[key], { matchBase: true })) {
return false;
}
}
@@ -53,4 +55,4 @@ exports.attach = function () {
}
}
});
-};
+};
View
4 package.json
@@ -2,7 +2,7 @@
"name": "forever",
"preferGlobal": "true",
"description": "A simple CLI tool for ensuring that a given node script runs continuously (i.e. forever)",
- "version": "0.9.0",
+ "version": "0.9.1",
"author": "Nodejitsu Inc <info@nodejitsu.com>",
"contributors": [
{ "name": "Charlie Robbins", "email": "charlie@nodejitsu.com" },
@@ -28,7 +28,7 @@
"daemon": "https://github.com/AvianFlu/daemon.node/tarball/master",
"flatiron": "0.1.x",
"microtime": "0.2.x",
- "minimatch": "0.0.x",
+ "minimatch": "0.2.x",
"nconf": "0.5.x",
"nssocket": "0.3.x",
"node-fork": "0.4.x",
Something went wrong with that request. Please try again.