Make forever safer for servers #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this work? I noticed an uncatched error in a script that wasn't noticed before caught node in a crashloop, making node+mongodb use 100% cpu because forever would restart the script the next clockcycle it was crashed. There should be a grace-period for restarting or something. |
|
I like your idea of warning people, but we can't change the CLI behavior this dramatically. |
This was referenced Apr 21, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have run into a number of gotchas in the past arising from:
I resolved this by forcing the command parameter, and adding defaults to both minUptime and max.
Kinda defeats some of the simple use cases, but making the program safer by default could be a good idea.