Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
CLI fixup and support for log rotation #359
Just submitted my first pull req ever on the forever-monitor project; this request is dependent on that one ... please let me know if there is a cleaner way to handle this.
I've added support here (mostly documentation) for rotating child process logs based on strftime formatting in the log file names.
I've also made a minor change to how the root directory for forever is set, first checking the FOREVER_ROOT environment variable. I noticed that it was problematic to set an alternate directory on the cli (chicken and egg problem), so thought this would be a simple, reasonable change.
Finally, I noticed that certain command line arguments (for example, debug) were never getting passed around properly. There were two issues: 1) options need to be added to an array in the cli.getOptions function in order to get passed around and 2) forever.load needs to be explicit passed options from the command line, otherwise its options are never updated.
Please let me know if I misunderstood what was going on and mucked it all up. :-)