CLI fixup and support for log rotation #359

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
@brettpaden

Just submitted my first pull req ever on the forever-monitor project; this request is dependent on that one ... please let me know if there is a cleaner way to handle this.

I've added support here (mostly documentation) for rotating child process logs based on strftime formatting in the log file names.

I've also made a minor change to how the root directory for forever is set, first checking the FOREVER_ROOT environment variable. I noticed that it was problematic to set an alternate directory on the cli (chicken and egg problem), so thought this would be a simple, reasonable change.

Finally, I noticed that certain command line arguments (for example, debug) were never getting passed around properly. There were two issues: 1) options need to be added to an array in the cli.getOptions function in order to get passed around and 2) forever.load needs to be explicit passed options from the command line, otherwise its options are never updated.

Please let me know if I misunderstood what was going on and mucked it all up. :-)

Brett and others added some commits Nov 29, 2012

Brett
Two things: fix the broken command line processing. Command line argu…
…ments were not being passed becuase forever.load was call before parsing took place. Second, support was added in the options for log rotation in the forever-monitor logger plugin
@indexzero

This comment has been minimized.

Show comment Hide comment
@indexzero

indexzero Apr 21, 2013

Owner

winston now has this functionality. We should leverage that.

Owner

indexzero commented Apr 21, 2013

winston now has this functionality. We should leverage that.

@indexzero indexzero closed this Apr 21, 2013

@kusold kusold referenced this pull request in foreverjs/forever-monitor Nov 7, 2013

Closed

Rewrite of logger plugin in order to support date based log rotation #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment