fixed binary support + mocha test + refactoring #12

Merged
merged 11 commits into from Jul 11, 2012

Conversation

Projects
None yet
3 participants
Contributor

kilianc commented Jul 11, 2012

No description provided.

@0x00A 0x00A pushed a commit that referenced this pull request Jul 11, 2012

Paolo Fragomeni Merge pull request #12 from kilianc/clearstream
fixed binary support + mocha test + refactoring
8642beb

@0x00A 0x00A merged commit 8642beb into foreverjs:master Jul 11, 2012

0x00A commented Jul 11, 2012

Ok, now im going to start running this in my dev env to see what happens ;)

0x00A commented Jul 11, 2012

Also, an additional trivial example in the readme would be kick ass.

Contributor

kilianc commented Jul 11, 2012

It will ;)

Owner

indexzero commented Jul 13, 2012

-1 to Mocha

0x00A commented Jul 13, 2012

I'm indifferent. I plan to turn these into pure asserts.

On Jul 12, 2012, at 9:44 PM, Charlie Robbinsreply@reply.github.com wrote:

-1 to Mocha


Reply to this email directly or view it on GitHub:
nodejitsu#12 (comment)

Contributor

kilianc commented Jul 18, 2012

@hij1nx how is going?

0x00A commented Jul 20, 2012

im not seeing any issues with this, i've been using it in dev, i think we need to turn tests into pure asserts before i publish. @indexzero is really into vows, and I am anti-framework. the only middle ground we really have is that if we dont use vows, we dont use anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment