FORGE-2283: Provide a method for updating the user's installation automatically #547
Conversation
|
|
||
| @Inject | ||
| @WithAttributes(label = "Name", description = "The addon's \"groupId:artifactId\" name", required = true) | ||
| private UIInput<String> name; |
There was a problem hiding this comment.
Better rename this to "named" to comply with other addons
|
Build 778 outcome was FAILURE using a merge of ec8687b Build problems:Failed tests detected Failed tests |
mbriskar
force-pushed
the
addon-update
branch
3 times, most recently
from
b610ac3
to
ea9854a
Compare
| maxAddonId = id; | ||
| } | ||
| } | ||
| addonManager.install(maxAddonId).perform(); |
There was a problem hiding this comment.
Perhaps it would be better to check if the maxAddonId isn't the same as the current
There was a problem hiding this comment.
Also addonManager.install() returns an object stating what will change when perform() is called, it would be nice to display that too and maybe prompt for execution
|
Build 779 outcome was FAILURE using a merge of ea9854a Build problems:Failed tests detected Failed tests |
|
Build 780 outcome was FAILURE using a merge of ea9854a Build problems:Failed tests detected Failed tests |
|
Thanks George, I added prompt and checked the already installed addons before the update. |
|
Build 781 outcome was FAILURE using a merge of e37059a Build problems:Failed tests detected Failed tests |
|
Build 782 outcome was FAILURE using a merge of e37059a Build problems:Failed tests detected Failed tests |
|
No tests? :) |
| { | ||
| MetadataFacet facet = project.getFacet(MetadataFacet.class); | ||
| Coordinate c = facet.getOutputDependency().getCoordinate(); | ||
| named.setDefaultValue(AddonId.from(c.getGroupId() + ":" + c.getArtifactId(), c.getVersion()) |
There was a problem hiding this comment.
This doesn't seem right. The current project may not be an addon project
There was a problem hiding this comment.
Oops, it is the copy/paste issue.
Will write tests, I was not sure I go the right direction with this command. However there is no test for addon-install either, or is there?
|
Build 783 outcome was FAILURE using a merge of e37059a Build problems:Failed tests detected Failed tests |
|
Build 806 outcome was FAILURE using a merge of e37059a Build problems:Failed tests detected Failed tests |
|
Build 789 outcome was FAILURE using a merge of e37059a Build problems:Failed tests detected Failed tests |
mbriskar
force-pushed
the
addon-update
branch
2 times, most recently
from
f93b6ba
to
64b893a
Compare
|
Build 804 outcome was FAILURE using a merge of 64b893a Build problems:Failed tests detected Failed tests |
|
Build 821 outcome was FAILURE using a merge of 64b893a Build problems:Failed tests detected Failed tests |
|
Build 805 outcome was FAILURE using a merge of 6e7cfff Build problems:Failed tests detected Failed tests |
|
Build 806 outcome was FAILURE using a merge of 6e7cfff Build problems:Failed tests detected Failed tests |
|
Build 822 outcome was FAILURE using a merge of 6e7cfff Build problems:Failed tests detected Failed tests |
|
Build 823 outcome was FAILURE using a merge of 6e7cfff Build problems:Failed tests detected Failed tests |
|
Build 824 outcome was FAILURE using a merge of 6e7cfff Build problems:Failed tests detected Failed tests |
|
I think this didn't cause this exception:
in the FacesScaffoldTest, or did it? |
|
Build 807 outcome was FAILURE using a merge of 00b12e1 Build problems:Failed tests detected Failed tests |
|
Build 808 outcome was FAILURE using a merge of 00b12e1 Build problems:Failed tests detected Failed tests |
|
Merged, thanks! |
No description provided.