Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Rebase "reword" editor should not silently forget changes #93

Closed
sm-g opened this issue Dec 29, 2018 · 8 comments
Closed

Interactive Rebase "reword" editor should not silently forget changes #93

sm-g opened this issue Dec 29, 2018 · 8 comments
Milestone

Comments

@sm-g
Copy link

@sm-g sm-g commented Dec 29, 2018

  1. go into interactive rebase, select "reword"
  2. type something into editor
  3. click somewhere in Rebase window (to select current title of commit for example) or Alt+Tab to other window to copy text from it
  4. all you have typed lost

https://i.imgur.com/wHjaM8o.gifv

expected: do not close this popup, make it another window (and ask for saving when user try to reword other line)

version: 1.21.1.0

PS. That is why I have learned to never use Interactive Rebase in SourceTree.

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Dec 29, 2018

all you have typed lost

No. I just tried and Fork remembered the incomplete message and restored it when I started editing the message again.

Loading

@sm-g
Copy link
Author

@sm-g sm-g commented Dec 29, 2018

@DanPristupov I have added gif record

Loading

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Jan 16, 2019

Sorry for the delay.

OK, I reproduced the bug. The message is not saved after the focus loose.

Loading

@DanPristupov DanPristupov added this to the 1.27 milestone Jan 16, 2019
@PeterPuff
Copy link

@PeterPuff PeterPuff commented Feb 10, 2019

Sorry, but behaviour is unchanged in 1.27 ;)

Loading

@sm-g
Copy link
Author

@sm-g sm-g commented Feb 13, 2019

And because commit message editor is splitted into 2 text boxes (#154), its impossible to copypaste message during reword!

Loading

@sm-g
Copy link
Author

@sm-g sm-g commented Mar 8, 2019

@DanPristupov what's with this (annoying) issue? There is 1.29 release already exists

Loading

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Mar 8, 2019

We didn't have time to look into this yet.

Loading

@DanPristupov DanPristupov removed this from the 1.27 milestone Mar 8, 2019
@DanPristupov DanPristupov added this to the 1.34 milestone Jun 6, 2019
@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Jun 8, 2019

In 1.34 we improved the IR usability and the problem with disappearing dialog should not occur anymore.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants