[Bug] Strange highlight of diff

[sm-g]

Fork:

VisualStudio / GitKraken:

[Otiel]

This is always confusing and that makes me check twice if I didn't mess the first letter of the Import word.

[Otiel]

Here's another one:

Only the following text has been added at the end of the file:

## New release

[This template](new-release.md) defines the basic steps that should be followed when creating a new release. It should be copied to each repository and adapted with specific rules if needed.

[DanPristupov]

The line [7] used to be ended without \n symbol.

In the update you added \n to the end of [7] and also added some other lines.

The \n symbol is hidden but it also belongs to lines.

Update:

So, in your case the source was like following:

## Git workflow\n
\n
Repositories must follow the git workflow defined [ere](git-forkflow.ms).

And here's the new version:

## Git workflow\n
\n
Repositories must follow the git workflow defined [ere](git-forkflow.ms).\n
## New release\n
\n
[This template](new-release.md) defines the basic steps that should be followed when creating a new release. It should be copied to each repository and adapted with specific rules if needed.

The 'No newline at end of file' hint is important :).

[Otiel]

Fair enough for the \n character.

But why is the No newline at end of file displayed twice, and not only once at the end of the diff?

[DanPristupov]

Because No newline at end of file is related to the last line, not to the whole diff.

[jerone]

@DanPristupov commented on Mar 21, 2019, 10:55 AM GMT+1:

Because No newline at end of file is related to the last line, not to the whole diff.

It would be nice if that message could be replaced by something visual. Every time I see that message, I wonder if I wrote that 😊

[Otiel]

Because No newline at end of file is related to the last line, not to the whole diff.

That makes sense. 👌

Fair enough for the \n character.

Coming back on this, is there any way you could visually highlight the \n? See for instance this diff:

[DanPristupov]

The algorithmic part is not difficult, however I'm not sure if the AvalonEdit control supports such rendering of \n symbol.

[DanPristupov]

The original issue fixed in 1.31