New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google maps is geolocating incorrectly in some countries #1860

Open
GhaziTriki opened this Issue Nov 30, 2016 · 29 comments

Comments

Projects
None yet
6 participants
@GhaziTriki
Contributor

GhaziTriki commented Nov 30, 2016

Type

  • Non critical bug

Problem description

ForkCMS puts the street number before the street name for geolocating addresses. The address number should come first.

Steps to reproduce

Create a location with the following parameters:

  • Street name: Rue de Annaba
  • Street number: 16
  • ZIP: 2074
  • City: Mourouj

The geolocated address is incorrect.

Expected behavior / Proposed solutions

Put the street number before the street name when geolocating.

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Nov 30, 2016

Member

can you provide a link to the documentation stating this?

Member

carakas commented Nov 30, 2016

can you provide a link to the documentation stating this?

@carakas carakas added RFC Unconfirmed and removed RFC labels Nov 30, 2016

@StijnVrolijk

This comment has been minimized.

Show comment
Hide comment
@StijnVrolijk

StijnVrolijk Nov 30, 2016

Contributor

What exactly does Fork request?
[Streetname][Streetnumber][Zip][City] should be the logical structure but Google is pretty smart about this. I've used the geocoding api quite a few times and it handles everything i throw at it

Contributor

StijnVrolijk commented Nov 30, 2016

What exactly does Fork request?
[Streetname][Streetnumber][Zip][City] should be the logical structure but Google is pretty smart about this. I've used the geocoding api quite a few times and it handles everything i throw at it

@GhaziTriki

This comment has been minimized.

Show comment
Hide comment
@GhaziTriki

GhaziTriki Nov 30, 2016

Contributor

I have found an element of answer at this link : http://stackoverflow.com/questions/7764244/correct-address-format-to-get-the-most-accurate-results-from-google-geocoding-ap

And in the official geocoder sample : http://googlemaps.github.io/js-v2-samples/geocoder/singlegeocode.html the address number comes first.

In all application I have developed the house number comes before the street name and I didn't see any coutnry that put the house number after the street name, is it the case in Belgium?

Contributor

GhaziTriki commented Nov 30, 2016

I have found an element of answer at this link : http://stackoverflow.com/questions/7764244/correct-address-format-to-get-the-most-accurate-results-from-google-geocoding-ap

And in the official geocoder sample : http://googlemaps.github.io/js-v2-samples/geocoder/singlegeocode.html the address number comes first.

In all application I have developed the house number comes before the street name and I didn't see any coutnry that put the house number after the street name, is it the case in Belgium?

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Nov 30, 2016

Member

it is indeed :)

Member

carakas commented Nov 30, 2016

it is indeed :)

@carakas carakas added Bug and removed Unconfirmed labels Nov 30, 2016

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Nov 30, 2016

Member

@GhaziTriki can you create a PR for this?

Member

carakas commented Nov 30, 2016

@GhaziTriki can you create a PR for this?

@GhaziTriki

This comment has been minimized.

Show comment
Hide comment
@GhaziTriki

GhaziTriki Nov 30, 2016

Contributor

@carakas yes it should be an easy one (if I find the file where I need to look inside). Which is file is it?

Contributor

GhaziTriki commented Nov 30, 2016

@carakas yes it should be an easy one (if I find the file where I need to look inside). Which is file is it?

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Nov 30, 2016

Member
Member

carakas commented Nov 30, 2016

@GhaziTriki

This comment has been minimized.

Show comment
Hide comment
@GhaziTriki

GhaziTriki Nov 30, 2016

Contributor

@carakas is it also ok to put the street number before the street name in the backend form?

Contributor

GhaziTriki commented Nov 30, 2016

@carakas is it also ok to put the street number before the street name in the backend form?

@StijnVrolijk

This comment has been minimized.

Show comment
Hide comment
@StijnVrolijk

StijnVrolijk Nov 30, 2016

Contributor

@GhaziTriki I think it's best to leave it as is. When looking at other countries ( http://www.bitboost.com/ref/international-address-formats.html ) I think most of them use the street + number format.

Contributor

StijnVrolijk commented Nov 30, 2016

@GhaziTriki I think it's best to leave it as is. When looking at other countries ( http://www.bitboost.com/ref/international-address-formats.html ) I think most of them use the street + number format.

@GhaziTriki

This comment has been minimized.

Show comment
Hide comment
@GhaziTriki

GhaziTriki Nov 30, 2016

Contributor

I have created a pull request. However I think that the address creation should be more flexible. What we have now is that all fields are mandatory. The street number and the zip code should be optional as the street name and the city should be enough, or at least the street number.

Contributor

GhaziTriki commented Nov 30, 2016

I have created a pull request. However I think that the address creation should be more flexible. What we have now is that all fields are mandatory. The street number and the zip code should be optional as the street name and the city should be enough, or at least the street number.

@tijsverkoyen

This comment has been minimized.

Show comment
Hide comment
@tijsverkoyen

tijsverkoyen Nov 30, 2016

Member

Personally, I think the address should be a textarea. People can enter the address in their own format.

Member

tijsverkoyen commented Nov 30, 2016

Personally, I think the address should be a textarea. People can enter the address in their own format.

@GhaziTriki

This comment has been minimized.

Show comment
Hide comment
@GhaziTriki

GhaziTriki Nov 30, 2016

Contributor

@tijsverkoyen it is a more flexible solution that should work better

Contributor

GhaziTriki commented Nov 30, 2016

@tijsverkoyen it is a more flexible solution that should work better

@jeroendesloovere jeroendesloovere changed the title from Goole maps is geolocating incorrectly to Google maps is geolocating incorrectly Dec 2, 2016

@carakas carakas changed the title from Google maps is geolocating incorrectly to Google maps is geolocating incorrectly in some countries Dec 10, 2016

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Dec 10, 2016

Member

@GhaziTriki I closed your PR because the implementation would cause issues for people who have street + number in their country.

What I suggest is that you create a new pr and add a setting in the backend to the location module where you can set the format of the address. The default should be the format we have now, but then you can also add the format you need

Member

carakas commented Dec 10, 2016

@GhaziTriki I closed your PR because the implementation would cause issues for people who have street + number in their country.

What I suggest is that you create a new pr and add a setting in the backend to the location module where you can set the format of the address. The default should be the format we have now, but then you can also add the format you need

@carakas carakas added this to the 5.0.0 milestone Jan 13, 2017

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Jan 13, 2017

Member

the separate fields will be replaced with a single textarea for the address

Member

carakas commented Jan 13, 2017

the separate fields will be replaced with a single textarea for the address

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas
Member

carakas commented Mar 27, 2017

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere
Member

jeroendesloovere commented May 16, 2017

@GhaziTriki Are you willing to create a PR using https://github.com/commerceguys/addressing?

@GhaziTriki

This comment has been minimized.

Show comment
Hide comment
@GhaziTriki

GhaziTriki Jun 2, 2017

Contributor

@jonasdekeukelaere I have some time. How do you think we can implement it?

Contributor

GhaziTriki commented Jun 2, 2017

@jonasdekeukelaere I have some time. How do you think we can implement it?

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Jun 6, 2017

Member

@GhaziTriki we should implement it in a way that it works for everywhere, maybe just a text area? Or with that library, don't know exactly what is possible

Member

carakas commented Jun 6, 2017

@GhaziTriki we should implement it in a way that it works for everywhere, maybe just a text area? Or with that library, don't know exactly what is possible

@jonasdekeukelaere

This comment has been minimized.

Show comment
Hide comment
@jonasdekeukelaere

jonasdekeukelaere Jun 8, 2017

Contributor

Hi @GhaziTriki - Did you start this? I can start this now otherwise, I'll add a textarea, as that way everyone is free to use whatever format they please.

Contributor

jonasdekeukelaere commented Jun 8, 2017

Hi @GhaziTriki - Did you start this? I can start this now otherwise, I'll add a textarea, as that way everyone is free to use whatever format they please.

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Jun 8, 2017

Member

If I'm remembering correct we decided in the core meeting that a single textarea was NOT the way we should go.

Member

jeroendesloovere commented Jun 8, 2017

If I'm remembering correct we decided in the core meeting that a single textarea was NOT the way we should go.

@tijsverkoyen

This comment has been minimized.

Show comment
Hide comment
@tijsverkoyen

tijsverkoyen Jun 8, 2017

Member

Euh, I remember that a texture was the way to go. As that allows people to enter/format the address as they want.

Member

tijsverkoyen commented Jun 8, 2017

Euh, I remember that a texture was the way to go. As that allows people to enter/format the address as they want.

@jonasdekeukelaere

This comment has been minimized.

Show comment
Hide comment
@jonasdekeukelaere

jonasdekeukelaere Jun 8, 2017

Contributor

So @jeroendesloovere I'll implement it as a textarea

Contributor

jonasdekeukelaere commented Jun 8, 2017

So @jeroendesloovere I'll implement it as a textarea

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Jun 8, 2017

Member

In the last core meeting (Tijs wasn't present then) we decided that if we use textarea. Lots of users wil lose the enormous features separate fields have to offer; "country", "zip", "city".

I must say that we used those fields a lot to create smart functionality like you can see in the screenshot below:
schermafbeelding 2017-06-08 om 11 45 14

Member

jeroendesloovere commented Jun 8, 2017

In the last core meeting (Tijs wasn't present then) we decided that if we use textarea. Lots of users wil lose the enormous features separate fields have to offer; "country", "zip", "city".

I must say that we used those fields a lot to create smart functionality like you can see in the screenshot below:
schermafbeelding 2017-06-08 om 11 45 14

@tijsverkoyen

This comment has been minimized.

Show comment
Hide comment
@tijsverkoyen

tijsverkoyen Jun 8, 2017

Member

And how will you solve the issue of addresses in different address-formats?

Member

tijsverkoyen commented Jun 8, 2017

And how will you solve the issue of addresses in different address-formats?

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Jun 8, 2017

Member

Looking at https://github.com/commerceguys/addressing,
they have the following fields:
schermafbeelding 2017-06-08 om 11 46 49

So if I'm correct merging "street + number/bus" would be "address line 1" or "address line 2" (if there is an industrial zone to mention).

Member

jeroendesloovere commented Jun 8, 2017

Looking at https://github.com/commerceguys/addressing,
they have the following fields:
schermafbeelding 2017-06-08 om 11 46 49

So if I'm correct merging "street + number/bus" would be "address line 1" or "address line 2" (if there is an industrial zone to mention).

@tijsverkoyen

This comment has been minimized.

Show comment
Hide comment
@tijsverkoyen

tijsverkoyen Jun 8, 2017

Member

The screenshots shows non-standard behaviour, and I don't see any Issues/Pull Requests that asks for extra functionality, so I don't see any reason to add extra dependencies, or make the interface more bloated.

Member

tijsverkoyen commented Jun 8, 2017

The screenshots shows non-standard behaviour, and I don't see any Issues/Pull Requests that asks for extra functionality, so I don't see any reason to add extra dependencies, or make the interface more bloated.

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Jun 8, 2017

Member

The actual problem of @GhaziTriki is that "streetnumber" should come before "street".
=> So why don't we create one textfield for "address line 1" (= street + number)
And leave the other fields untouched... (zip and city)

Member

jeroendesloovere commented Jun 8, 2017

The actual problem of @GhaziTriki is that "streetnumber" should come before "street".
=> So why don't we create one textfield for "address line 1" (= street + number)
And leave the other fields untouched... (zip and city)

@tijsverkoyen

This comment has been minimized.

Show comment
Hide comment
@tijsverkoyen

tijsverkoyen Jun 8, 2017

Member

In some countries (e.g.: UK) the zip isn't placed before the city.

Member

tijsverkoyen commented Jun 8, 2017

In some countries (e.g.: UK) the zip isn't placed before the city.

@GhaziTriki

This comment has been minimized.

Show comment
Hide comment
@GhaziTriki

GhaziTriki Jun 8, 2017

Contributor

As a reminder http://www.bitboost.com/ref/international-address-formats.html
Every country has its own address standard.

Contributor

GhaziTriki commented Jun 8, 2017

As a reminder http://www.bitboost.com/ref/international-address-formats.html
Every country has its own address standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment