New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the Pages module: `yarn add jstree` and `yarn add jquery.cookie` #1999

Open
jeroendesloovere opened this Issue Mar 6, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@jeroendesloovere
Member

jeroendesloovere commented Mar 6, 2017

Type

  • Enhancement

Problem description

We want to use yarn for the jstree in the Backend Pages (& MediaLibrary module). The files from "Pages module" could be replaced by yarn add jstree and yarn add jquery.cookie. But I was yet unable (lack of time) to get things working, since their are breaking changes in these classes...

Note

Address the Pull Request to the "fork-cms-5.0.0-dev" branch

@jeroendesloovere jeroendesloovere added this to the 5.0.0 milestone Mar 6, 2017

@jeroendesloovere jeroendesloovere changed the title from For the Pages module: `yarn add to For the Pages module: `yarn add jstree` and `yarn add jquery.cookie` Mar 6, 2017

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Jun 8, 2017

Member

@jessedobbelaere did you find some time fixing this one?

Member

jeroendesloovere commented Jun 8, 2017

@jessedobbelaere did you find some time fixing this one?

@jessedobbelaere

This comment has been minimized.

Show comment
Hide comment
@jessedobbelaere

jessedobbelaere Aug 2, 2017

Contributor

Yep looking into it. Not sure if this is an "easy pick" as we're upgrading from jsTree 0.9.9 (2009) to 3.3.4 (2017) :P But can't be that hard to make it working again, right

Contributor

jessedobbelaere commented Aug 2, 2017

Yep looking into it. Not sure if this is an "easy pick" as we're upgrading from jsTree 0.9.9 (2009) to 3.3.4 (2017) :P But can't be that hard to make it working again, right

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Aug 2, 2017

Member

wow, we are way behind :p @jessedobbelaere how is it going?

Member

carakas commented Aug 2, 2017

wow, we are way behind :p @jessedobbelaere how is it going?

@jessedobbelaere jessedobbelaere referenced a pull request that will close this issue Aug 3, 2017

Open

Pagetree update + yarn [WIP] #2157

@carakas carakas removed the Nice to have 5 label Aug 4, 2017

@carakas carakas modified the milestones: 5.1.0, 5.0.0 Aug 4, 2017

@carakas carakas removed the Hacktoberfest label Sep 29, 2017

@carakas carakas modified the milestones: 5.1.0, 5.2.0 Jan 23, 2018

@StijnVrolijk StijnVrolijk modified the milestones: 5.2.0, 5.3.0 Feb 9, 2018

@carakas carakas modified the milestones: 5.3.0, 5.3.1, 5.4.0 May 28, 2018

@carakas carakas modified the milestones: 5.4.0, 5.5.0 Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment