New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to control the amount of items that are being linked with the media library #2034

Closed
carakas opened this Issue May 3, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@carakas
Member

carakas commented May 3, 2017

Type

  • Enhancement

Problem description

At the moment there is no way as a developer to impact the amount of items that the media library can connect

if I just want one item, or 4 or something between 3 and 7 that is not possible at the moment

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere
Member

jeroendesloovere commented May 3, 2017

👍

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere May 3, 2017

Member

Possible solution

Adding two new options to the MediaGroupType could take care of this in the Backend:

  • 'minimum_items' => 3
  • 'maximum_items' => 7

schermafbeelding 2017-05-03 om 16 30 23

@carakas what do you think of this solution?

Other bad solution

And not: adding variables to the entity for this, for the reason that, if you have a custom module with 10000 connected MediaGroup entities and the customer wants this changed, you're screwed a little...

Member

jeroendesloovere commented May 3, 2017

Possible solution

Adding two new options to the MediaGroupType could take care of this in the Backend:

  • 'minimum_items' => 3
  • 'maximum_items' => 7

schermafbeelding 2017-05-03 om 16 30 23

@carakas what do you think of this solution?

Other bad solution

And not: adding variables to the entity for this, for the reason that, if you have a custom module with 10000 connected MediaGroup entities and the customer wants this changed, you're screwed a little...

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas May 3, 2017

Member

I think that is a good solution, maybe then also automagically add a constraint for it

Member

carakas commented May 3, 2017

I think that is a good solution, maybe then also automagically add a constraint for it

@carakas carakas added this to the 5.2.0 milestone Jan 24, 2018

@StijnVrolijk StijnVrolijk modified the milestones: 5.2.0, 5.3.0 Feb 9, 2018

@carakas carakas modified the milestones: 5.3.0, 5.3.1, 5.4.0 May 28, 2018

@carakas carakas added the Easy Pick label Aug 6, 2018

@carakas carakas self-assigned this Aug 6, 2018

@carakas carakas added the Has PR label Aug 6, 2018

@carakas carakas closed this Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment