New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the implementation of Frontend/Core/Engine/Rss away from spoon library #2098

Open
carakas opened this Issue Jun 14, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@carakas
Member

carakas commented Jun 14, 2017

Type

  • Enhancement

Problem description

We are using Spoon rss, since spoon is deprecated we should swap it out

Expected behavior / Proposed solutions

Keep the same external api but let it work on a different library or implementation

@carakas carakas added this to the 5.0.0 milestone Jun 14, 2017

@carakas carakas changed the title from Change the implementation of Core/Engine/Rss away from spoon library to Change the implementation of Frontend/Core/Engine/Rss away from spoon library Jun 14, 2017

@carakas carakas added the RFC label Jun 14, 2017

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Jun 14, 2017

Member

Suggestions welcome on what we should use instead

Member

carakas commented Jun 14, 2017

Suggestions welcome on what we should use instead

@jonasdekeukelaere

This comment has been minimized.

Show comment
Hide comment
@jonasdekeukelaere

jonasdekeukelaere Jun 14, 2017

Contributor

I don't know any bundles or symfony stuff for that. Maybe an XML writer (with custom implementation for feeds)?

Contributor

jonasdekeukelaere commented Jun 14, 2017

I don't know any bundles or symfony stuff for that. Maybe an XML writer (with custom implementation for feeds)?

@tijsverkoyen

This comment has been minimized.

Show comment
Hide comment
@tijsverkoyen
Member

tijsverkoyen commented Jul 25, 2017

https://github.com/alexdebril/rss-atom-bundle?
Or just some twig-template?

@carakas carakas removed the Nice to have 5 label Aug 1, 2017

@carakas carakas modified the milestones: 5.1.0, 5.0.0 Aug 1, 2017

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Aug 1, 2017

Member

if this can be implemented in a BC way it can be done in 5.1 else it wil be 6

Member

carakas commented Aug 1, 2017

if this can be implemented in a BC way it can be done in 5.1 else it wil be 6

@tijsverkoyen tijsverkoyen modified the milestones: 5.1.0, 6.0.0 Aug 2, 2017

@carakas carakas modified the milestones: 5.1.0, 6.0.0 Aug 3, 2017

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Oct 19, 2017

Member

https://github.com/alexdebril/rss-atom-bundle seems indeed like a nice one!
It uses providers.
So we can for example create a .../Blog/Provider/BlogRssFeedProvider.php.

Member

jeroendesloovere commented Oct 19, 2017

https://github.com/alexdebril/rss-atom-bundle seems indeed like a nice one!
It uses providers.
So we can for example create a .../Blog/Provider/BlogRssFeedProvider.php.

@tijsverkoyen

This comment has been minimized.

Show comment
Hide comment
@tijsverkoyen

tijsverkoyen Oct 19, 2017

Member

I don't agree at all. A module should be responsible for its own feeds, not a global RSS-feed.

Member

tijsverkoyen commented Oct 19, 2017

I don't agree at all. A module should be responsible for its own feeds, not a global RSS-feed.

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Oct 31, 2017

Member

@tijsverkoyen nobody needs a global RSS-feed indeed... Don't know why you say this...

Some more information about RSS Atom bundle:

  • There is a controller that can generate a RSS feed.
  • You just have to throw a provider at it, that will automatically generate a rss feed from the FeedInterface that contains the items.
    <route id="your_route_name" pattern="/your/route/{contentId}">
        <default key="_controller">DebrilRssAtomBundle:Stream:index</default>
        <default key="format">rss</default>
        <default key="source">your.provider.service</default>
    </route>

your.provider.service can be for example BlogArticleFeedProvider or FaqQuestionFeedProvider, ...

** Provider **
In the getFeedContent() method you must return a FeedInterface.

Documentation:

Member

jeroendesloovere commented Oct 31, 2017

@tijsverkoyen nobody needs a global RSS-feed indeed... Don't know why you say this...

Some more information about RSS Atom bundle:

  • There is a controller that can generate a RSS feed.
  • You just have to throw a provider at it, that will automatically generate a rss feed from the FeedInterface that contains the items.
    <route id="your_route_name" pattern="/your/route/{contentId}">
        <default key="_controller">DebrilRssAtomBundle:Stream:index</default>
        <default key="format">rss</default>
        <default key="source">your.provider.service</default>
    </route>

your.provider.service can be for example BlogArticleFeedProvider or FaqQuestionFeedProvider, ...

** Provider **
In the getFeedContent() method you must return a FeedInterface.

Documentation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment