New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI console default environment #2236

Closed
myspulin opened this Issue Sep 7, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@myspulin

myspulin commented Sep 7, 2017

  • Enhancement

Problem description

Hi,

I use ForkCms on production server and I wonder why is in console default environment set to dev:

$env = $input->getParameterOption(array('--env', '-e'), getenv('SYMFONY_ENV') ?: 'dev');

In the commnad list there is writen that default shoud be prod:

-e, --env=ENV The Environment name. [default: "prod"]

Could you please check it and update the code.

Thank you! Love this app very much.

Lukas

Steps to reproduce

Unset te env variable and run the console command.

Expected behavior / Proposed solutions

Default environment should be PROD.

@myspulin

This comment has been minimized.

Show comment
Hide comment
@myspulin

myspulin commented Sep 15, 2017

Thanks.

@myspulin myspulin closed this Sep 15, 2017

@carakas carakas reopened this Sep 18, 2017

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Sep 18, 2017

Member

Ow sorry, the pr that needed to fix this had closed this one automatically, but it isn't fixed yet, the solution that I had tried kept failing in the test so I closed (not merged it)

Member

carakas commented Sep 18, 2017

Ow sorry, the pr that needed to fix this had closed this one automatically, but it isn't fixed yet, the solution that I had tried kept failing in the test so I closed (not merged it)

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas May 29, 2018

Member

symfony 4 states that it needs to be dev

Member

carakas commented May 29, 2018

symfony 4 states that it needs to be dev

@carakas carakas closed this May 29, 2018

@ohvitorino

This comment has been minimized.

Show comment
Hide comment
@ohvitorino

ohvitorino May 29, 2018

Contributor

@carakas Can you add a link to the Symfony documentation?

Contributor

ohvitorino commented May 29, 2018

@carakas Can you add a link to the Symfony documentation?

@carakas

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment