New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Media Links module #2350

Closed
jeroendesloovere opened this Issue Nov 6, 2017 · 10 comments

Comments

Projects
None yet
4 participants
@jeroendesloovere
Member

jeroendesloovere commented Nov 6, 2017

Type

  • Feature

Problem description

Wouldn't it be nice if there was a module that allowed you to add "links" to "social media channels".
Almost every website has links to "Facebook", "Twitter", "Instagram", ... But if the link changes or a (new) social media channel needs to be added/removed that is something that a developer needs to adjust...

Creating a module that allows you to add a "social media link" solves that problem.

Entity SocialMediaLink:

  • SocialMediaType $type - All possible bootstrap social media icons; "facebook", "instagram", ...
  • string $url - External link to that channel

Result

A widget that automatically shows the icons.
schermafbeelding 2017-11-06 om 14 35 27

@wouterverstuyf

This comment has been minimized.

Show comment
Hide comment
@wouterverstuyf

wouterverstuyf Nov 22, 2017

Contributor

Good idea!
Is a seperate module required for this? I think the location module could be upgraded with this.

I've created this feature in (a copy of) the location module, and added a checkbox to set a location as a "main contact" (= the company main address and other info).
The widgets "sociallinks" get the social media links from the main contact and put them with the correct icons.

schermafbeelding 2017-11-22 om 14 08 55

Contributor

wouterverstuyf commented Nov 22, 2017

Good idea!
Is a seperate module required for this? I think the location module could be upgraded with this.

I've created this feature in (a copy of) the location module, and added a checkbox to set a location as a "main contact" (= the company main address and other info).
The widgets "sociallinks" get the social media links from the main contact and put them with the correct icons.

schermafbeelding 2017-11-22 om 14 08 55

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Nov 22, 2017

Member

My initial thought is/was to create a separate module for this...

But if you want we can create an association between "SocialMediaLinks" and "Locations" module, that can even improve the way you currently work in the location module screenshot that you have displayed.

EXAMPLE:
SocialMediaLink entity:

  • Social media channel (dropdown); facebook, twitter, linkedin, ...
  • URL

Location entity:

  • Title
  • ...
  • Collection of SocialMediaLinks, "+ add social media link" --> choose the existing SocialMediaLinks from a dropdown.

Advantage: if a social media link gets updated, it gets updated on all locations... idem when it gets deleted...

Member

jeroendesloovere commented Nov 22, 2017

My initial thought is/was to create a separate module for this...

But if you want we can create an association between "SocialMediaLinks" and "Locations" module, that can even improve the way you currently work in the location module screenshot that you have displayed.

EXAMPLE:
SocialMediaLink entity:

  • Social media channel (dropdown); facebook, twitter, linkedin, ...
  • URL

Location entity:

  • Title
  • ...
  • Collection of SocialMediaLinks, "+ add social media link" --> choose the existing SocialMediaLinks from a dropdown.

Advantage: if a social media link gets updated, it gets updated on all locations... idem when it gets deleted...

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Nov 22, 2017

Member

But like I said, i suggest a separate module.

Member

jeroendesloovere commented Nov 22, 2017

But like I said, i suggest a separate module.

@jacob-v-dam

This comment has been minimized.

Show comment
Hide comment
@jacob-v-dam

jacob-v-dam Dec 7, 2017

Contributor

I've created a module which enables a user to set the credentials like @wouterverstuyf. But you can add a formbuilder item which creates custom widgets which show a form. Like:

image

And create custom contact widgets:
image

And social media ofcourse:
image

Contributor

jacob-v-dam commented Dec 7, 2017

I've created a module which enables a user to set the credentials like @wouterverstuyf. But you can add a formbuilder item which creates custom widgets which show a form. Like:

image

And create custom contact widgets:
image

And social media ofcourse:
image

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Dec 11, 2017

Member

that module looks nice :)

Member

carakas commented Dec 11, 2017

that module looks nice :)

@wouterverstuyf

This comment has been minimized.

Show comment
Hide comment
@wouterverstuyf

wouterverstuyf Dec 11, 2017

Contributor

Another handy feature to make it complete, is the possibility to add opening hours to a contact, and display them as a widget. I'm testing this now:

schermafbeelding 2017-12-11 om 10 08 08

schermafbeelding 2017-12-11 om 10 09 55

Contributor

wouterverstuyf commented Dec 11, 2017

Another handy feature to make it complete, is the possibility to add opening hours to a contact, and display them as a widget. I'm testing this now:

schermafbeelding 2017-12-11 om 10 08 08

schermafbeelding 2017-12-11 om 10 09 55

@jacob-v-dam

This comment has been minimized.

Show comment
Hide comment
@jacob-v-dam

jacob-v-dam Dec 11, 2017

Contributor

Well we could extend this module with that feature.

Contributor

jacob-v-dam commented Dec 11, 2017

Well we could extend this module with that feature.

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Dec 11, 2017

Member

we could, you can always create a PR for it and we can take a look then if it would be a good extension. It would be even nicer if you used symfony form and doctrine. We are currently working in the 6.0.0-dev branch to switch everything internally to doctrine.

Member

carakas commented Dec 11, 2017

we could, you can always create a PR for it and we can take a look then if it would be a good extension. It would be even nicer if you used symfony form and doctrine. We are currently working in the 6.0.0-dev branch to switch everything internally to doctrine.

@jacob-v-dam

This comment has been minimized.

Show comment
Hide comment
@jacob-v-dam

jacob-v-dam Dec 11, 2017

Contributor

My module is fully doctrine, In created a repository:
https://github.com/jacob-van-dam-ict/fork-cms-contact

Contributor

jacob-v-dam commented Dec 11, 2017

My module is fully doctrine, In created a repository:
https://github.com/jacob-van-dam-ict/fork-cms-contact

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Dec 11, 2017

Member

I would do some things slightly different but it certainly looks like a good start. From what I can see you can only have one location now. The current location module can have more than one location, but I could be wrong.

Member

carakas commented Dec 11, 2017

I would do some things slightly different but it certainly looks like a good start. From what I can see you can only have one location now. The current location module can have more than one location, but I could be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment