New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend js: statistics ":external" bug? #2359

Closed
jeroendesloovere opened this Issue Nov 15, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@jeroendesloovere
Member

jeroendesloovere commented Nov 15, 2017

Type

  • Non critical bug

Problem description

It seems that :external excludes mailto <a href buttons?
https://github.com/forkcms/forkcms/blob/master/src/Frontend/Core/Js/frontend.js#L529

While the lines below want to set mailto click events...
https://github.com/forkcms/forkcms/blob/master/src/Frontend/Core/Js/frontend.js#L546

Proposed solutions

I guess the wanted behavior is that the mailto click events should get tracked.
So the external function is wrong...
My suggestion: removing the && !obj.href.match(/^mailto:/)

Correct?

@carakas carakas added this to the 5.2.3 milestone Feb 14, 2018

carakas added a commit to justcarakas/forkcms that referenced this issue Mar 12, 2018

@carakas carakas added the Has PR label Mar 12, 2018

@carakas carakas self-assigned this Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment