New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageType and FileType don't work in Fork CMS 5.0.7 #2373

Closed
jeroendesloovere opened this Issue Nov 29, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@jeroendesloovere
Member

jeroendesloovere commented Nov 29, 2017

Type

  • Non critical bug

Problem description

Since the symfony/symfony update from v3.3.6 to 3.3.13, in Fork CMS 5.0.7, ImageType (and probably FileType) aren't working anymore. When saving, the error Compound forms expect an array or NULL on submission. is thrown.

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Nov 29, 2017

Member

Seems like stdClass can't be used anymore? Only array and null.
But don't how how to fix it for the moment.

Member

jeroendesloovere commented Nov 29, 2017

Seems like stdClass can't be used anymore? Only array and null.
But don't how how to fix it for the moment.

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Nov 29, 2017

Member

This is the bug:
schermafbeelding 2017-11-29 om 16 55 20

This is how it's configured

use Common\Form\ImageType;

$builder
            ->add(
                'image',
                ImageType::class,
                [
                    'label' => 'lbl.Image',
                    'image_class' => Image::class,
                    'required' => true,
                ]
            )
Member

jeroendesloovere commented Nov 29, 2017

This is the bug:
schermafbeelding 2017-11-29 om 16 55 20

This is how it's configured

use Common\Form\ImageType;

$builder
            ->add(
                'image',
                ImageType::class,
                [
                    'label' => 'lbl.Image',
                    'image_class' => Image::class,
                    'required' => true,
                ]
            )
@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Nov 30, 2017

Member

the transformer should take care of switching the type
Unless symfony broke some things within a minor version it would seem strange to me that that is the issue

Member

carakas commented Nov 30, 2017

the transformer should take care of switching the type
Unless symfony broke some things within a minor version it would seem strange to me that that is the issue

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Dec 7, 2017

Member

@jeroendesloovere was this fixed with #2374 ?

Member

carakas commented Dec 7, 2017

@jeroendesloovere was this fixed with #2374 ?

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere
Member

jeroendesloovere commented Dec 11, 2017

@carakas no.

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Dec 21, 2017

Member

@jeroendesloovere can you send me an example on slack of code that triggers this error

Member

carakas commented Dec 21, 2017

@jeroendesloovere can you send me an example on slack of code that triggers this error

@jeroendesloovere

This comment has been minimized.

Show comment
Hide comment
@jeroendesloovere

jeroendesloovere Jan 9, 2018

Member

@carakas every module that has ImageType and FileType...
Any news on a fix?

Member

jeroendesloovere commented Jan 9, 2018

@carakas every module that has ImageType and FileType...
Any news on a fix?

@cirykpopeye

This comment has been minimized.

Show comment
Hide comment
@cirykpopeye

cirykpopeye Jan 9, 2018

Contributor

I'm having the same issue with my modules using the ImageType from Fork. Form errors are throwing 'This value is not valid' for the image field.

Contributor

cirykpopeye commented Jan 9, 2018

I'm having the same issue with my modules using the ImageType from Fork. Form errors are throwing 'This value is not valid' for the image field.

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Jan 9, 2018

Member

I was on vacation for 2 weeks :) I'll probably have time for it tomorrow and I'll release 5.0.8 afterwards

Member

carakas commented Jan 9, 2018

I was on vacation for 2 weeks :) I'll probably have time for it tomorrow and I'll release 5.0.8 afterwards

@carakas

This comment has been minimized.

Show comment
Hide comment
@carakas

carakas Jan 9, 2018

Member

since this is the last open issue

Member

carakas commented Jan 9, 2018

since this is the last open issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment