New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External url's validated incorrectly in a Docker #2388

Closed
mathiashelin opened this Issue Dec 29, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@mathiashelin
Contributor

mathiashelin commented Dec 29, 2017

Type

  • Non critical bug

Problem description

When using addJS(), it checks the url with $this->get(fork.validator.url)->isExternalUrl($file), which has checkDNS set on true. Adding an external js file returns false when working in a local Docker environment, while it should return true.

Steps to reproduce

Try using something like $this->addJS('https://github.com').

Expected behavior / Proposed solutions

External urls should be validated as external urls, even in a local Docker environment. so maybe checkDNS should be set to false in debug mode.

@carakas carakas added this to the 5.1.0 milestone Jan 24, 2018

@carakas carakas added the Has PR label Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment