New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ajax-loader.gif #2489

Closed
Sellato opened this Issue Feb 25, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@Sellato
Contributor

Sellato commented Feb 25, 2018

Type

  • Non critical bug

Problem description

Error 404 missing ajax-loader.gif - src/Frontend/Themes/Fork/Core/Layout/Css/ajax-loader.gif

Steps to reproduce

src/Frontend/Themes/Fork/Core/Layout/Css/ajax-loader.gif

Expected behavior / Proposed solutions

We need to generate new ajax-loader.gif using http://www.ajaxload.info/ and put it at src/Frontend/Themes/Fork/Core/Layout/Css/ajax-loader.gif

Thanks.

@carakas

This comment has been minimized.

Member

carakas commented Feb 25, 2018

@Katrienvh why are we using a gif and not an icon font?

@jessedobbelaere

This comment has been minimized.

Contributor

jessedobbelaere commented Feb 25, 2018

If possible I would even use a css-only spinner:

Normally they support all latests browsers and IE10+ (but <=IE9 fallback is possible)

@carakas carakas added this to the 5.4.1 milestone Aug 7, 2018

@carakas carakas added the Has PR label Oct 11, 2018

@carakas carakas assigned carakas and unassigned Katrienvh Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment