New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR: lock user logins when a data leak occurred #2512

Open
jeroendesloovere opened this Issue Mar 9, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@jeroendesloovere
Member

jeroendesloovere commented Mar 9, 2018

Type

  • Feature

Problem description

GDPR is almost there.
It is our task to provide solutions in Fork CMS for when a data leak has occurred.

  1. User sessions must be deleted.

  2. Users must reset their password.
    When a data leak has occurred (database credentials leaked, ...),
    it must be possible to prevent users from logging in anymore...
    Until they have reset their password, using a received "reset your password" mail.

@StijnVrolijk

This comment has been minimized.

Contributor

StijnVrolijk commented Mar 9, 2018

That doesn't sound like anything Fork needs to worry about. I'm sure @tijsverkoyen can elaborate on that.

Other than that: that feature sounds super dangerous for 'regular' users

@jeroendesloovere

This comment has been minimized.

Member

jeroendesloovere commented Mar 9, 2018

@StijnVrolijk

When somebody had access to database credentials.
He can do whatever he wants, including pasting in $password and $passwordKey from his local Fork CMS. Et voila, a data breach has occured. Because he now has access to fork cms and can do whatever he wants.

To prevent the hacker accessing the CMS another time (after all passwords are changed or a leak has been closed), we must disable every user and make sure they reset their password.

@tijsverkoyen

This comment has been minimized.

Member

tijsverkoyen commented Mar 9, 2018

Most of the things that need to be done to be compliant with GDPR are the responsibility of the developer. In the core there are some multiple things that can be implemented, but I am trying to compose of list of things that have to be changed, and stuff that are nice to have.

Jeroen's request is something we can implement, I will add it to my list.

@tijsverkoyen

This comment has been minimized.

Member

tijsverkoyen commented Mar 9, 2018

@jeroendesloovere when someone has access to the database you have bigger issues ;-)

@jeroendesloovere

This comment has been minimized.

Member

jeroendesloovere commented Mar 9, 2018

I know,

but the feature I suggest is for afterwards, to (try) to tighten your CMS again.
After you have reset all your passwords (cpanel, ftp, database, API-keys, ...)

@jeroendesloovere jeroendesloovere changed the title from GDPR: protect users when a data leak occurred to GDPR: lock user logins when a data leak occurred Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment