New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media library: folder name longer than one word #2565

Closed
Katrienvh opened this Issue Jun 8, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@Katrienvh
Contributor

Katrienvh commented Jun 8, 2018

Type

  • Non critical bug

Problem description

The white spaces from a folder with a name longer then one word got replaced by -

Steps to reproduce

Add a folder with a name longer then one word.
You can see the issue in the folder tree or when you edit the folder

@jeroendesloovere

This comment has been minimized.

Member

jeroendesloovere commented Jul 2, 2018

Hi @Katrienvh

So, if I'm correct, what you want is that we do not urlize "folder names" anymore?

@StijnVrolijk

This comment has been minimized.

Contributor

StijnVrolijk commented Jul 2, 2018

@jeroendesloovere why not seperate the name and the uri? A folder with whitespaces in it is a perfectly valid folder, the URI should not influence the name of the folder

@Katrienvh

This comment has been minimized.

Contributor

Katrienvh commented Jul 2, 2018

What Stijn says is exactly my point: the URI should not influence the name of the folder

@jeroendesloovere

This comment has been minimized.

Member

jeroendesloovere commented Jul 2, 2018

A little history

One of the reasons why I decided to go for "URI"-name instead of a "name",
was that it was easier to have if somebody wanted to create custom integrations like f.e.: moving all media library files to folders on another FileSystem of using Cloud services like Amazon, Dropbox, ...

But currently "URI" seems obsolete.
Since I haven't heard anybody doing such things (which require "urlized" folder name), we can probably remove the urlization entirely....

Conclusion: proposed solution

The database field in MediaFolder is called name.
=> We can remove the urlisation entirely and start using "normal names".
=> Backwards compatible.

@carakas carakas added the Easy Pick label Aug 6, 2018

@carakas carakas self-assigned this Aug 6, 2018

@carakas carakas changed the title from Media library: folder name longer then one word to Media library: folder name longer than one word Aug 6, 2018

@carakas carakas added the Has PR label Aug 6, 2018

@carakas carakas closed this Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment