New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application install - database password is required #2623

Open
myspulin opened this Issue Aug 23, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@myspulin

myspulin commented Aug 23, 2018

Type

  • Enhancement

Problem description

When install application in step 4 database password is required. When I have user "root" without password on my local dev environment I cannot continue with the installation. I undrestand that use no password is not save but for dev usage it should not be a problem. So to finish installation I have to update the file src\ForkCMS\Bundle\InstallerBundle\Form\Type\DatabaseType.php and add required to false.

->add(
'databasePassword',
PasswordType::class,
[
'required' => false,
]

Steps to reproduce

Process the installation to the step 4.

Expected behavior / Proposed solutions

Database password is not required.

@carakas carakas added this to the 5.4.1 milestone Aug 27, 2018

@carakas carakas referenced a pull request that will close this issue Sep 5, 2018

Open

Don't require a database password #2635

@carakas carakas self-assigned this Sep 5, 2018

@carakas carakas added the Has PR label Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment