Make sure SpoonSession is initialised before starting symfony session #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carakas
approved these changes
Apr 10, 2017
carakas
requested changes
Apr 10, 2017
app/Kernel.php
Outdated
| SpoonSession::start(); | ||
|
|
||
| /** @var \Symfony\Component\HttpFoundation\Session\Session $session */ | ||
| $session = $this->getContainer()->get('session'); |
There was a problem hiding this comment.
I would wrap this method still in a check where you check if the service exists, I think that in cases like a console command it doesnt exist, maybe in those cases also skipp strarting SpoonSession
There was a problem hiding this comment.
Also, starting a session, means a cookies, which sucks for caching.
There was a problem hiding this comment.
In my opinion, the session should only be started if it is needed.
There was a problem hiding this comment.
@tijsverkoyen this should be fixed in 3513b16 and that should also address my issue
carakas
force-pushed
the
fork-symfony-session-bridge
branch
from
dd950fc
to
779099c
Compare
carakas
approved these changes
Apr 13, 2017
carakas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
Symfony sessions did not work if they where started before the spoon sessions
Pull request description
In most cases we will only access the symfony sessions after SpoonSession has started. But in the cases where that is not the case the symfony sessions didn't work because of some stuff happening This will fix that issue by making sure that when we start the symfony sessions the SpoonSessions also have started.