New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to change the sequence of a collection type #2624

Merged
merged 2 commits into from Dec 20, 2018

Conversation

Projects
None yet
4 participants
@carakas
Copy link
Member

carakas commented Aug 27, 2018

Type

  • Feature

Pull request description

Adds the option to change the sequence of items in a collection

screen shot 2018-08-27 at 13 09 34

Todo

  • Documentation

@carakas carakas added this to the 5.5.0 milestone Aug 27, 2018

@@ -1516,6 +1569,7 @@
newWidget = newWidget.replace(/__id__/g, newName[1].replace(re, count))
var newLi = $('<li class="list-group-item"></li>').html(newWidget)
newLi.appendTo(list)
CollectionSequence.saveNewSequence(newLi.closest(sequenceField))

This comment has been minimized.

@ohvitorino

ohvitorino Nov 15, 2018

Contributor

This should be CollectionSequence.saveNewSequence(list) or CollectionSequence.saveNewSequence(newLi.closest('[data-role="collection-sequence"]')) if I'm not mistaken.

This comment has been minimized.

@carakas

carakas Dec 20, 2018

Author Member

fixed in b6698fc

@carakas carakas changed the title [WIP] Add the option to change the sequence of a collection type Add the option to change the sequence of a collection type Dec 20, 2018

@carakas carakas merged commit e549d27 into forkcms:master Dec 20, 2018

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carakas carakas deleted the justcarakas:enable-sequence-on-fork-collection-type branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment