New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a TitleType to easily add titles to your Fork CMS form! #2625

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@StijnVrolijk
Copy link
Contributor

StijnVrolijk commented Aug 28, 2018

Type

  • Feature

Pull request description

Create a TitleType to easily add titles to your Fork CMS form!

Provides everything from the required classes to the label. All overwritable, of course.

StijnVrolijk added some commits Aug 28, 2018

Create a TitleType to easily add titles to your Fork CMS form!
Provides everything from the required classes to the label. All overwritable, of course.

@StijnVrolijk StijnVrolijk added this to the 5.5.0 milestone Aug 28, 2018

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors Aug 28, 2018

$resolver->setDefaults(
[
'label' => 'lbl.Title',
'required' => true,

This comment has been minimized.

@carakas

carakas Aug 28, 2018

Member

is required not always true by default?

This comment has been minimized.

@StijnVrolijk

StijnVrolijk Aug 28, 2018

Author Contributor

It is but I decided to explicitly define it because it was defined in some other places (like ContentBlocks) and it's also clearer for users.

@carakas carakas merged commit 3b54987 into master Dec 19, 2018

5 checks passed

Scrutinizer 2 updated code elements
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carakas carakas deleted the title-type branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment