New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update form layout with panels #2626

Merged
merged 4 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@Katrienvh
Copy link
Contributor

Katrienvh commented Aug 28, 2018

Type

  • Enhancement

Pull request description

Do not wrap each form row in a panel.
Add layout for collectiontypes in forms

@Katrienvh Katrienvh force-pushed the Katrienvh:update-form-layout-with-panels branch from d4a1302 to e942447 Aug 28, 2018

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors Aug 28, 2018

@StijnVrolijk StijnVrolijk added this to the 5.5.0 milestone Aug 28, 2018

@StijnVrolijk
Copy link
Contributor

StijnVrolijk left a comment

Looking good!

@carakas

This comment has been minimized.

Copy link
Member

carakas commented Aug 28, 2018

@Katrienvh can you add screenshots? also for the collection as tab ?

@Katrienvh

This comment has been minimized.

Copy link
Contributor Author

Katrienvh commented Oct 29, 2018

screen-shot-2018-10-29-at-08 21 10

@carakas carakas merged commit ef816e6 into forkcms:master Dec 19, 2018

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment