New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpstan integration #2639

Merged
merged 18 commits into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@ohvitorino
Copy link
Contributor

ohvitorino commented Sep 7, 2018

Type

  • Enhancement

Pull request description

This PR aims to add static code analysis to ForkCMS.
The travis configuration was modified to have two stages. One that executes the unit and functional tests in parallel, and another stage (Code Quality) that runs PHPCS and PHPStan.

PHPStan does at this moment only level 0 analysis and my idea is to increase the level with time, so that the code can become more robust.

@ohvitorino ohvitorino force-pushed the ohvitorino:phpstan-integration branch from 53d69b5 to aea7a1f Nov 9, 2018

Show resolved Hide resolved phpstan.neon

@carakas carakas added this to the 5.5.0 milestone Dec 18, 2018

@tijsverkoyen tijsverkoyen self-requested a review Dec 20, 2018

@carakas carakas merged commit 118045c into forkcms:master Dec 20, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer Analysis: 2 new issues – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment