Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPhpstan integration #2639
Conversation
ohvitorino
added some commits
Sep 4, 2018
ohvitorino
force-pushed the
ohvitorino:phpstan-integration
branch
from
53d69b5
to
aea7a1f
Nov 9, 2018
carakas
requested changes
Nov 10, 2018
carakas
approved these changes
Dec 18, 2018
carakas
added this to the 5.5.0 milestone
Dec 18, 2018
tijsverkoyen
self-requested a review
Dec 20, 2018
tijsverkoyen
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ohvitorino commentedSep 7, 2018
Type
Pull request description
This PR aims to add static code analysis to ForkCMS.
The travis configuration was modified to have two stages. One that executes the unit and functional tests in parallel, and another stage (Code Quality) that runs PHPCS and PHPStan.
PHPStan does at this moment only level 0 analysis and my idea is to increase the level with time, so that the code can become more robust.