New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #2643

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@thibautvincent
Contributor

thibautvincent commented Sep 13, 2018

Type

  • Critical bugfix

Resolves the following issues

Fixes #2587

Pull request description

Because of the typo the value of directionsService was undefined.
This fix gives it the value null so we can compare correctly.

Fix typo
Because of the typo the value of `directionsService` was `undefined`.
This fix gives it the value `null` so we can compare correctly.

Closes #2587
@carakas

This comment has been minimized.

Member

carakas commented Sep 14, 2018

Thank you for this pr, was it used correctly in the rest of the js file?

@carakas

This comment has been minimized.

Member

carakas commented Sep 14, 2018

maybe related to #2587 ?

@thibautvincent

This comment has been minimized.

Contributor

thibautvincent commented Sep 14, 2018

@carakas Is indeed the fix for #2587

@carakas

carakas approved these changes Oct 2, 2018

@carakas carakas added this to the 5.4.1 milestone Oct 2, 2018

@carakas carakas merged commit 0eb0e99 into forkcms:master Oct 2, 2018

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thibautvincent thibautvincent deleted the thibautvincent:issue-2587 branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment