New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build the navigation cache if vital information has changed #2649

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
4 participants
@StijnVrolijk
Copy link
Contributor

StijnVrolijk commented Oct 5, 2018

Type

  • Enhancement

Pull request description

Only build the navigation cache if vital information has changed. When editing a page we don't need to rebuild the navigation cache if we only changed a typo or a block. It should only be rebuilt if the title, navigation_title or published properties changed.

This is a rather small enhancement but might be useful for sites with a lot of pages.

@StijnVrolijk StijnVrolijk added this to the 5.5.0 milestone Oct 5, 2018

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors Oct 5, 2018

@carakas carakas merged commit 2bac75d into master Dec 19, 2018

5 checks passed

Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carakas carakas deleted the only-rebuild-the-navigation-cache-if-vital-information-changed branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment