New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better breadcrumb support #2663

Merged
merged 4 commits into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@StijnVrolijk
Copy link
Contributor

StijnVrolijk commented Oct 17, 2018

Type

  • Feature

Resolves the following issues

Fixes #2629

Pull request description

Adds a simple method to the backend Header class with which we can easily add a breadcrumb item to the breadcrumbs. This is useful for displaying what you are uploading files in for example.

Before:
image

After:
image

@StijnVrolijk StijnVrolijk added this to the 5.5.0 milestone Oct 17, 2018

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors Oct 17, 2018

StijnVrolijk added some commits Oct 17, 2018

Allow an additional breadcrumb to be set
This is useful for display exactly what you are editing for example

@StijnVrolijk StijnVrolijk force-pushed the add-better-breadcrumb-support branch from d95d281 to bf713fb Oct 17, 2018

@@ -31,4 +31,7 @@
</li>
{% endif %}
{% endfor %}
{% if breadcrumbDetail %}

This comment has been minimized.

@carakas

carakas Oct 17, 2018

Member

have you tried this on a page where it wasn't defined?

This comment has been minimized.

@StijnVrolijk

StijnVrolijk Oct 17, 2018

Author Contributor

yes I have, no issues whatsoever

@@ -44,9 +44,11 @@ protected function parse(): void
/** @var int|null $mediaFolderId */
$mediaFolderId = ($this->mediaFolder instanceof MediaFolder) ? $this->mediaFolder->getId() : null;

This comment has been minimized.

@carakas

carakas Oct 17, 2018

Member

useless whitespace

This comment has been minimized.

@StijnVrolijk

StijnVrolijk Oct 17, 2018

Author Contributor

whoops

@carakas carakas merged commit 70011cf into master Dec 19, 2018

4 of 5 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
Scrutinizer 2 new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carakas carakas deleted the add-better-breadcrumb-support branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment