New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use find method instead of magic method #2674

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
4 participants
@ohvitorino
Copy link
Contributor

ohvitorino commented Nov 9, 2018

Type

  • Enhancement

Pull request description

This PR replaces the usage of the magic method findOneById with the method find in the MediaLibrary and MediaGallery modules.

@StijnVrolijk StijnVrolijk requested a review from forkcms/core-contributors Nov 9, 2018

@StijnVrolijk StijnVrolijk modified the milestones: 5.4.2, 5.5.0 Nov 9, 2018

@carakas

This comment has been minimized.

Copy link
Member

carakas commented Nov 10, 2018

@StijnVrolijk I think this one can be included in 5.4.2. Any reason why you changed it to 5.5.0?

@StijnVrolijk

This comment has been minimized.

Copy link
Contributor

StijnVrolijk commented Nov 12, 2018

@carakas sure but since it's an enhancement I thought it'd be better to release it in a feature release.

@carakas carakas merged commit b4ac456 into forkcms:master Dec 19, 2018

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment