New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer update symfony/phpunit-bridge #2688

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@StijnVrolijk
Copy link
Contributor

StijnVrolijk commented Dec 14, 2018

Type

  • Critical bugfix

Pull request description

Tests are failing because of sebastianbergmann/phpunit#3413
Updating the PHPUnit bridge of symfony relieves this issue.

@StijnVrolijk StijnVrolijk added this to the 5.4.2 milestone Dec 14, 2018

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors Dec 14, 2018

@WouterSioen

This comment has been minimized.

Copy link
Member

WouterSioen commented Dec 14, 2018

Can't we install an automatic dependency bumper that creates PR's whenever dependencies can go up in a non-breaking way? (f.e. https://dependabot.com/)

@StijnVrolijk

This comment has been minimized.

Copy link
Contributor Author

StijnVrolijk commented Dec 14, 2018

@WouterSioen good idea, I've installed the bot 👍

@carakas carakas merged commit 0071b40 into master Dec 18, 2018

5 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carakas carakas deleted the update-symfony-phpunit-bridge branch Dec 18, 2018

@carakas carakas modified the milestones: 5.4.2, 5.5.0 Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment