/forkcms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media gallery delete button #2694

Merged
merged 26 commits into from Dec 19, 2018

Conversation

Reviewers

@carakas carakas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  5.5.0
5 participants
@Katrienvh @carakas @bart-webleads @thibautvincent @StijnVrolijk
@Katrienvh
Copy link
Contributor

Katrienvh commented Dec 19, 2018

Type

  • Non critical bugfix

Pull request description

This wil fix the redirect to gallery overview when clicked on delete, tis was cause of the type submit on the delete button

carakas and others added some commits Sep 4, 2018

@carakas @Katrienvh
Media folders were sitll being encoded on edit
44c60e5
@carakas @Katrienvh
When using the modulesettings in your services the installation won't… 
… work anymore.

This pr fixes that issue by using acutal implimentations instead of stdClass
2c5c7d3
@bart-webleads @Katrienvh
Fix double escape for comment author name 
Fix not needed escape and unescape for comment text
Cleaned stupid comments
d67766c
@bart-webleads @Katrienvh
Update cronjob description 
With fork v5, the only option is command line, not website.
b0d1406
Jacob van Dam @Katrienvh
Fixed thumbnail resize
921881e
@thibautvincent @Katrienvh
Fix typo 
Because of the typo the value of `directionsService` was `undefined`.
This fix gives it the value `null` so we can compare correctly.

Closes #2587
845e567
Wouter Verstuyf @Katrienvh
Bugfix // Cast error on save
97dcf87
@StijnVrolijk @Katrienvh
Fix the HTTPS detection when getting the configuration during install
76ccb90
@carakas @Katrienvh
Add the transchoice to the language class 
This fixes the translations of things like the Count validation
a3a182a
@StijnVrolijk @Katrienvh
Check the value of $_SERVER['HTTPS'] if it's set 
From php.net:
Note that when using ISAPI with IIS, the value will be off if the request was not made through the HTTPS protocol.
c82a0ee
@carakas @Katrienvh
Make the backend navigation scrollable
d472715
@carakas @Katrienvh
Fix loader missing for slick slider 
No other way to fix this since this is an external dependency
1bb7561
@carakas @Katrienvh
Fix 404 caused by fix that fixes the initial building of css but fail… 
…s afterwards in the browser
1f5fad5
@carakas @Katrienvh
Compiled css
e4c8c8d
@carakas @Katrienvh
Fix fork settings not existing
503081d
@carakas @Katrienvh
Fix check if the comment needs to be moderated
d668144
@carakas @Katrienvh
Sort css alphabetically
0c2af86
@carakas @Katrienvh
Compiled css
bf9da2d
@carakas @Katrienvh
Fix autosuggest
68ecd5d
@carakas @Katrienvh
Fix cropping square pictures
e396f9e
@carakas @Katrienvh
Include source folder only returned the source folder
506da16
@carakas @Katrienvh
Hide the feedback box by default
c402f07
@carakas @Katrienvh
Submit the form when the question is useful, ask for feedback otherwise
085cfcd
@carakas @Katrienvh
Preparing for release
7dcba66
@Katrienvh
Do not submit on delete gallery, just open the modal
Loading status checks…
8b3f31e
@carakas
Merge branch 'master' into media-gallery-delete-button
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4f3d1e

@carakas carakas added this to the 5.4.2 milestone Dec 19, 2018

@carakas

carakas approved these changes Dec 19, 2018
View changes

@carakas carakas merged commit 5950f80 into forkcms:master Dec 19, 2018
3 checks passed

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carakas carakas modified the milestones: 5.4.2, 5.5.0 Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment