New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media gallery delete button #2694

Merged
merged 26 commits into from Dec 19, 2018

Conversation

Projects
None yet
5 participants
@Katrienvh
Copy link
Contributor

Katrienvh commented Dec 19, 2018

Type

  • Non critical bugfix

Pull request description

This wil fix the redirect to gallery overview when clicked on delete, tis was cause of the type submit on the delete button

carakas and others added some commits Sep 4, 2018

When using the modulesettings in your services the installation won't…
… work anymore.

This pr fixes that issue by using acutal implimentations instead of stdClass
Fix double escape for comment author name
Fix not needed escape and unescape for comment text
Cleaned stupid comments
Update cronjob description
With fork v5, the only option is command line, not website.
Fix typo
Because of the typo the value of `directionsService` was `undefined`.
This fix gives it the value `null` so we can compare correctly.

Closes #2587
Add the transchoice to the language class
This fixes the translations of things like the Count validation
Check the value of $_SERVER['HTTPS'] if it's set
From php.net:
Note that when using ISAPI with IIS, the value will be off if the request was not made through the HTTPS protocol.
Fix loader missing for slick slider
No other way to fix this since this is an external dependency

@carakas carakas added this to the 5.4.2 milestone Dec 19, 2018

@carakas carakas merged commit 5950f80 into forkcms:master Dec 19, 2018

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carakas carakas modified the milestones: 5.4.2, 5.5.0 Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment