New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "track" cookie #2719

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@bart-webleads
Copy link
Contributor

bart-webleads commented Jan 2, 2019

The "track" cookie was never set. It needed only a very small fix to enabled it ;-)

Type

  • Non critical bugfix

Pull request description

The "track" cookie did not work. It did not work from version 5.0.0 and up.
The visitorId never got set because of bad php code.

You can test this bug on the demo website. You don't see that a cookie "track" is ever created.
https://demo.fork-cms.com

bart-webleads and others added some commits Jan 2, 2019

Fix "track" cookie
The "track" cookie was never set. It needed only a very small fix to enabled it ;-)

@carakas carakas added this to the 5.5.0 milestone Jan 14, 2019

@carakas carakas merged commit 8d77133 into forkcms:master Jan 14, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment