New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed cookies fix #2720

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@bart-webleads
Copy link
Contributor

bart-webleads commented Jan 2, 2019

Type

  • Non critical bugfix

Pull request description

The hasAllowedCookies() function returns misleading values.

  • It was testing for 'N', while that should be 'Y'.
  • Because the default value is 'N' and it is testing for the value 'N', when no "cookie_bar_agree" was set, the function returns true.

This has been fixed.

bart-webleads and others added some commits Jan 2, 2019

allowed cookies fix
The hasAllowedCookies() function returns misleading values.

- It was testing for 'N', while that should be 'Y'.
- Because the default value is 'N' and it is testing for the value 'N', when no "cookie_bar_agree" was set, the function returns true.

This has been fixed.

@carakas carakas added this to the 5.5.0 milestone Jan 14, 2019

@carakas carakas merged commit eaf934a into forkcms:master Jan 14, 2019

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bart-webleads bart-webleads deleted the bart-webleads:patch-5 branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment