New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #2731

Merged

carakas merged 52 commits into master from cleanup

Jan 31, 2019

Member

Type

Cleanup and minor bugfixes based on scrutinizer


      Remove unused parameter

96483b4


      No need to use protected in a final class

9ba63c7


      Use the variable instead of getting the value again from the array

91e9397


      Swap out deprecated class to generate thumbnails


      Use the service instead of a static method to get the thumbnail folders

5faaeb6


      Use the service instead of a static method to get the thumbnail folde…

…rs in the blog model

dc4aae3


      Clean up phpdoc

36bd687


      Delete the image on page edit with the service instead of the static …

…method

ab764e0


      Clarify deprecation notice for PagesModel::createHtml

73ccf21


      Use the thumbnail service instead of the static method in the Abstrac…

…tImage

0f1f493


      Use thumbnail service instead of static method in Frontend Form image

f3d2282


      Use thumbnail service instead of static method for profile settings

602c2af


      Use the thumbnail service in the frontend blog model

93868d7


      Fix saving a draft of an existing blog post

53ce0a7


      Get the redirect url for blog edit save or save as draft

d63a9b5


      Make sure we don't install the module unless the form is valid

cf7f4b0


      Initialise the array for the templates with the data

442a28c


      Simplify the code for copying a translation

2b8ae5e


      Fix blog tests because the order of the parameters changed when optim…

…ising the code

d011af9


      Simplify handling the locale import

35b73a9


      Make sure we don't add child pages if we didn't add the parent page f…

…irst

fbb066a


      Make sure activeLanguages and redirect languages are defined

46e4109


      Don't split the assigning of the groups and the saving of the groups up

c3fd9bf


      Replace method that was removed in twig 2

2d48aec


      Cleanup type changes

e973c8b


      Remove dead code from BlogModel::getAllCommentsForStatus

ea932d7


      Remove dead code to turn meta into an array since it is already done …

…when calling the method

94a37e9


      Fix the check that prevents setting and empty text to the mail


      Fix phpdoc of the UTCDateTimeType DBAL Type

1a409f9


      Fix phpdoc of the UTCTimeType DBAL Type


      Fix phpdoc of the installationData since it can be null when there is…

… nothing in the session yet

bb4cb17


      Fix phpdoc in Media Library Actions

6bad557


      Fix the empty check for the map settings

1f31d61


      Fix the empty check of the facebookAppId

7652fd3


      Fix phpdoc of the visitorId

4d19c8c


      Move the exception when the module has not yet been set to a more log…

…ical place

d96bb9c


      Stict string comparison

c5c0c53


      Fix some phpdoc in the OneImage class

7b8685d


      Fix profile id not found error

3d2a3f3


      Improve the check if there is a replyTo set in the mail from the Form…

…BuilderSubmittedMailSubscriber

676f122


      Use the correct test to see if explode returned no results

7bb03d4


      Move the exception that lets us know we haven't set the module to a m…

…ore logical place

5c3eb7b


      Remove the declaration of the unused parameter dataGridCronjobs

ccff721


      Fix the check to see if we have a valid media folder id

c704ebc


      Get rid of false null pointer warnings in the ContentBlockDataTransfe…

…rObject

bdf080b


      Don't use exit but nicely pass it up the chain

6fae119


      Fix codestyle

f4d86d2


      Fix phpdoc

f58c40a


      Merge branch 'master' into cleanup

fd9c252


      Don't output void

614220f


      Merge branch 'cleanup' of github.com:forkcms/forkcms into cleanup

776f678


      Fix indendation of locale

c5c617f

Scrutinizer Analysis: 1 updated code elements – Tests: passed

Details

continuous-integration/styleci/pr The analysis has passed

Details

continuous-integration/styleci/push The analysis has passed

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

continuous-integration/travis-ci/push The Travis CI build passed

Details