Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy page button #2732

Merged
merged 13 commits into from May 21, 2019

Conversation

Projects
None yet
3 participants
@carakas
Copy link
Member

commented Jan 17, 2019

Type

  • Feature

Resolves the following issues

fixes #2721

Pull request description

This pr adds the option to create a new page based on the page you are currently viewing/editing.
During this implementation the missing authentication tab on page add was also added like it exists on the page edit action
screenshot 2019-01-24 at 10 08 27
screenshot 2019-01-24 at 10 08 13

@carakas carakas added this to the 5.6.0 milestone Jan 17, 2019

@carakas carakas requested review from forkcms/core-contributors Jan 17, 2019

@carakas carakas added the Pages label Jan 17, 2019

@freshface

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Would 'Copy this page' not be a better translation?

@carakas

This comment has been minimized.

Copy link
Member Author

commented Jan 17, 2019

The reason why I called it clone is because of the definition of the words

clone - create something new based on something that exists.
copying - copy from something that exists to something else (that also already exists).

Additionally I wanted to avoid confusion with copying to the clipboard

@mathiashelin

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Maybe use duplicate?

@carakas

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2019

Changed it back to copy after the feedback

@carakas carakas changed the title Clone page button Copy page button Jan 24, 2019

@carakas carakas force-pushed the justcarakas:2721-page-duplicate-button branch from 7c260c3 to 86bd07b May 20, 2019

@carakas carakas merged commit 591d493 into forkcms:master May 21, 2019

3 checks passed

Scrutinizer 4 updated code elements
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.