Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad value for time element #2788

Merged
merged 2 commits into from May 20, 2019

Conversation

Projects
None yet
2 participants
@bart-webleads
Copy link
Contributor

commented Apr 9, 2019

Type

  • Non critical bugfix

Pull request description

validator.W3.org reports this error:
Bad value 2019-02-04CET09,35,00 for attribute datetime on element time: The literal did not satisfy the time-datetime format.
Also removed the milliseconds modifier, second should be fine.

bart-webleads added some commits Apr 9, 2019

Fix bad value for time element
validator.W3.org reports this error:
Bad value 2019-02-04CET09,35,00 for attribute datetime on element time: The literal did not satisfy the time-datetime format.
@carakas

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

@Katrienvh can you look at this since you changed in a commit to fix the invalid format

@carakas carakas requested a review from Katrienvh Apr 9, 2019

@carakas carakas added this to the 5.5.3 milestone Apr 9, 2019

@carakas

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@bart-webleads can you remove the commit that adds the milliseconds?
It gets through the validator with the milliseconds, unless you have a specific reason why they should be removed cause they were recently added

@bart-webleads

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

@carakas

When you add a blog post in the backend, the publish_on field (time) can be entered as "hh:mm" Seconds are not allowed here!

So all datetime stamps for the publish_on column in the blog table look like this:
2018-09-05 07:35:00
2018-09-05 07:37:00
2018-09-05 07:39:00
2016-09-05 07:31:00
2017-09-05 07:31:00
........
Seconds and also milliseconds are not used and are all set to "zero".

So, why should we bother to print milliseconds when these are always set to zero???

@carakas

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Oki

@carakas carakas merged commit 9df9cbb into forkcms:master May 20, 2019

3 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bart-webleads bart-webleads deleted the bart-webleads:patch-datetime branch May 20, 2019

@carakas carakas modified the milestones: 5.5.3, 6.0.0, 5.6.0 May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.