Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix youtube and vimeo in the media gallery #2816

Merged

Conversation

Projects
None yet
3 participants
@carakas
Copy link
Member

commented May 21, 2019

Type

  • Non critical bugfix

Resolves the following issues

fixes #2791

Pull request description

The media gallery widgets didn't work with youtube and vimeo video's. That has been fixed now.
Also the video's now have thumbnails in the backend.

@carakas carakas added this to the 5.5.3 milestone May 21, 2019

@carakas carakas requested a review from forkcms/core-contributors May 21, 2019

@carakas carakas modified the milestones: 5.5.3, 5.6.0 May 21, 2019

@carakas carakas force-pushed the justcarakas:2791-youtube-in-media-gallery-not-working branch from ce02345 to b61cfdb May 21, 2019

@jeroendesloovere
Copy link
Member

left a comment

The provided solution is good for me.

@jeroendesloovere

This comment has been minimized.

Copy link
Member

commented May 22, 2019

The only thing of feedback I can provide is that it should be better if we move all HTML outside of the PHP classes. Perhaps using a setting with %1$s to replace filename, etc...

Example, replacing

return '<iframe src="' . $this->includeUrl . $mediaItem->getUrl() . '?color=ffffff&title=0&byline=0&portrait=0&badge=0" width="100%" height="100%" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>';

by

return sprintf(
    $this->htmlForInclusion,
    $this->includeUrl . $mediaItem->getUrl()
);

Which would make it editable on the fly by other users.

@carakas

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

@jeroendesloovere going to leave it like this. You can always change it in the php if needed. And with the width stuff it will take the size of it's parent so you can control it like that

@carakas carakas merged commit c675d69 into forkcms:master Jun 26, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carakas carakas deleted the justcarakas:2791-youtube-in-media-gallery-not-working branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.